Patches attached. Libraries fix will improve library detection and requirements fix for sure will not fail with minified versions of both libraries.

CommentFileSizeAuthor
#1 Issue-2008162-by-hass-Requirements-hook-can-be-clean.patch3.66 KBhass
libraries_fix.patch1.36 KBaleksey.tk
requirements_fix.patch1.21 KBaleksey.tk

Comments

hass’s picture

hass commented
Version: 7.x-1.0-alpha10 » 7.x-1.x-dev
Status: Active » Needs review
StatusFileSize
new Issue-2008162-by-hass-Requirements-hook-can-be-clean.patch3.66 KB

Attaching a re-roled patch with new modernizer and some code style issues fixed.

jessebeach’s picture

jessebeach commented
Issue summary: View changes
Issue tags: +rc-blocker
hass’s picture

hass commented
jessebeach’s picture

jessebeach commented
Status: Needs review » Fixed

Thanks hass, shumushin.

Committed to 7.x-1.x in 1e4083b9149276123ee19f5ceba0ed31663c7e85

Do either of you know how to get the minified files to load? I'm hoping there is some way to load the regular files when devel is enabled and the minified files when its not. I'm not getting much help from the Libraries module docs or examples.

designerbrent’s picture

designerbrent commented

It's only trying to load the non-minified versions for me, even if that is the only version available.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.