remove $.browser (Remove IE 6 support)

Hello!
I have many errors in my console, so I created a patch.
Please review.

Just have added --author to patch, sorry. And attached error apearing in console.

Actually, I've no intentions to support IE6 even further. Actually reminds me to drop the workarounds from the D7+8 branches...

Posted by sun on August 18, 2011 at 6:44am

in #1031850: Ensure compatibility with IE6 when using position fixed

So just drop the entire section :)

OK. Patch below removes support of IE6.

5: admin_menu-remove-ie6-support-1892074-5.patch queued for re-testing.

Hi all: I had this problem because I was running JQuery Update for another module that required it. In the jQuery Update configuration (admin/config/development/jquery_update) I was able to select the Default jQuery Version to be 1.7. This appears to be adequate for now for both my version of Admin Menu (7.x-3.0-rc4) and the other module (TB Mega Menu 7.x-1.0-beta2+0-dev).

@Katharine_Gates: This is because jQuery 1.7 still has the $.browser function.

Patch works smoothly with jQuery update and jQuery 1.9!

Please commit, IE6 market share is now far below 5%, site builders and editors who are using IE6 should be bashed and burn in hell! (Apologies for the wording...)

For usage statistics follow these links:
http://www.w3schools.com/browsers/browsers_explorer.asp (0.1%)
http://www.netmarketshare.com/report.aspx?qprid=3&qpaf=&qpcustom=Microso... (4.92%)
http://gs.statcounter.com/#browser_version-ww-monthly-201211-201311-bar (IE6 is no more listed)
http://www.w3counter.com/globalstats.php (IE6 is no more listed)
http://clicky.com/marketshare/global/web-browsers/internet-explorer/ (0.33%)

Patch applied to latest dev. Works like a charm. Please commit this. It's very disruptive and causes the JS engine to halt.

+1 for committing this.

Still waiting on this, and the patch in #5 still works perfectly. Thanks!

Stumbled upon this just now when I needed to upgrade my jQuery to 1.11.0 . This bug breaks some other modules and basic Drupal functionality, like vertical tabs not showing and leaving field groups impossible to expand.

However, removing all the older $.browser stuff straight away might be undesired. There are other solutions for detecting IE6.

p0wer, can you present your case for retaining IE6 support? Do you really have that many (/any) users who administer sites using IE6?

I don't need IE6 support and none of editors/admins use it anymore since these are most often people familiar with at least basic technology and realize that using IE6 is like digging in a rock. They don't even use IE anymore unless required to, so I'm fine without IE6 support. Besides, the only place I might think of where you can stumble on IE6 nowadays is out-of-the-box Windows Server 2003 and older, and of course freshly installed XP.

IMCE has its own method of detecting IE which is regexp on browser name, also seen suggestions of using Modernizr.js as a replacement solution.

Committed to 7.x-3.x and 8.x-3.x.

Great. Thanks.

I am running the latest stable version (after this commit) and I still see
Uncaught TypeError: Cannot read property 'msie' of undefined
error in my console on every page where admin menu is present.

Using jQuery 2.1 with jQuery update module (7.x-3.0-alpha3)

Is that still related to this?!

@kopeboy , I just searched through admin_menu 7.x-3.0-alpha3 source code for 'msie'
msie is not found, so its gone, I'm not sure where you're getting this from, please try testing on a vanilla d7 installation. For yours, search through your javascript , this msie must be comming from elsewhere, or else needs a cache clear.

Thanks