Civi Bartik is a wider, recolorable admin theme for CiviCRM based on Drupal Core's Bartik theme. This theme is to be used mainly for CiviCRM backend to get a clean/wider look of CiviCRM backend pages/form.

When using Bartik as CiviCRM admin theme, CiviCRM pages/forms gets compressed because of the centered & narrow content area and the pages/forms looks messy. This theme is a copy of Drupal Core's Bartik theme, with some changes in the CSS for making CiviCRM backend pages/form look cleaner by using the empty spaces on left/right side of the main content area.

The CSS changes can be documented and done in Bartik theme, but as Bartik is a core theme, i dont want the user to lose the changes during drupal upgrade. Hence releasing this theme to cater for wider CiviCRM pages/forms without losing it during drupal upgrade process.

Project page: https://drupal.org/sandbox/rajeshrhino/2117585

git repository: http://git.drupal.org/sandbox/rajeshrhino/2117585.git

git clone --branch 7.x-1.x http://git.drupal.org/sandbox/rajeshrhino/2117585.git civi_bartik

Intended Drupal core version
Drupal 7.x

Comments

PA robot’s picture

PA robot commented
Status: Needs review » Needs work

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxrajeshrhino2117585git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

rajeshrhino’s picture

rajeshrhino commented
Status: Needs work » Needs review

Fixed errors reported by automated review tools from pareview.sh

oresh’s picture

oresh commented
Title: Civi Bartik » [D7] Civi Bartik
Issue summary: View changes

Changed title and git clone link - please follow https://drupal.org/node/1011698

oresh’s picture

oresh commented
Status: Needs review » Needs work

rajeshrhino, thanks for your work!
Your templates look good and well commented, your template.php is clean clear and using correct conditions :)
You could try to use drupal_render for civi_bartik_field__taxonomy_term_reference function I guess, but it's not critical.

There are some minor notices from me:

1) If your theme is based on Bartik, why don't you base theme in your .info file?

2) you sure you need a clearfix on every menu?

function civi_bartik_menu_tree($variables) {
  return '<ul class="menu clearfix">' . $variables['tree'] . '</ul>';
}

3) You don't have to align the element in array with brackets:

drupal_add_css(path_to_theme() . '/css/ie.css', array(
                                                         'group' => CSS_THEME,
                                                         'browsers' => array(
                                                           'IE' => 'lte IE 7',
                                                           '!IE' => FALSE),
                                                         'preprocess' => FALSE));

Rather than that your code looks good to go.

rajeshrhino’s picture

rajeshrhino commented

Hi oresh

Thanks for the review

I have fixed the below points you mentioned

1. Added base theme information in .info file
2. Clearfix is not required in every menu. Removed the clearfix
3. Fixed the alignment

rajeshrhino’s picture

rajeshrhino commented
Status: Needs work » Needs review
cellar door’s picture

cellar door commented
Status: Needs review » Reviewed & tested by the community

Did a code walkthrough and an install on a basic site (not even a civi site). As a themer the templates, coding and changes you've made all make sense and work well in this situation. I didn't see any issues come up in the review so I'm setting RTBC. Great theme, I'll keep it in mind for future civi projects!

kscheirer’s picture

kscheirer
Primary language English
Location Vallejo
commented
Status: Reviewed & tested by the community » Fixed
  • You have a typo, ADMINSTRATION should be ADMINISTRATION.
  • Your screenshot it tiny! A bigger one would be nice.
  • You have a Thumbs.db file in the color/ and images/ directories that I don't think you need.

None of those are blocking issues though.

Thanks for your contribution, rajeshrhino!

I updated your account to let you promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and get involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.

----
Top Shelf Modules - Crafted, Curated, Contributed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.