[D7] Date Block

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Module works fine, block gets created and date is shown on enabling the block.

In the settings at admin/config/date_block, if the textfield is left empty and saved, no date is shown in the block which is right according to the code. It might be good to show a date with default format or put a check that empty value is not supported. Just a suggestion.

There is no version branch in git. Please follow the instructions related to git structure from here - https://drupal.org/node/1127732 and to set a default branch https://drupal.org/node/1659588

Hey Flexman,

data_block.install, line 22.
Don't use db_query for running delete queries; instead use https://api.drupal.org/api/drupal/includes!database!database.inc/functio...

date_block.module, line 82.
hook_block_view will only invoke blocks defined by your module. This means unless you're going to add more blocks you don't need to perform a switch statement.

For a block focused module I wouldn't implement a menu hook & separate form to store the block settings. This creates confusion. Instead have a look at https://api.drupal.org/api/drupal/modules!block!block.api.php/function/h... &
https://api.drupal.org/api/drupal/modules!block!block.api.php/function/h...

Both of the above hooks are much more suited to your module.

Just a suggestion but I wouldn't worry about including a hook_install. Set your default value where you first implement date_block_default_format, which would be in the setting form in this case.

/**
 * Admin settings.
 */
function date_block_admin_settings() {

  $form['date_block_default_format'] = array(
    '#type' => 'textfield',
    '#title' => t('Date Format'),
    '#description' => t('Enter a user-defined date format. See the !url for available options.', array('!url' => l(t('PHP manual'), 'http://php.net/manual/function.date.php'))),
    '#default_value' => variable_get('date_block_default_format', "F j, Y"),
    '#required' => TRUE,
  );

  return system_settings_form($form);
}

Cheers,

Getting some fatal errors using the git repository path provided. Use
git clone --branch master http://git.drupal.org/sandbox/flexman/2141203.git date_block

You should change the URL to clone the project to

git clone --branch 7.x-1.x http://git.drupal.org/sandbox/flexman/2141203.git date_block

Your URL is for the maintainer.

Manual Review:

date_block.install line #22
Use variable_del() function to remove variable on uninstall hook would be ideal. So replace
db_query("DELETE FROM {variable} WHERE name LIKE 'date_block_%'");
with
variable_del('date_block_default_format');

date_block.module line #98
It would be good, if you can use Ternary Operator instead of if/else.

So replace below code in _date_block_content() function

if (variable_get('date_block_default_format')) {
    $date_format = variable_get('date_block_default_format');
  }
  else {
    $date_format = 'F j, Y';
  }

with

$date_format = variable_get('date_block_default_format');
$date_format = !empty($date_format) ? $date_format : 'F j, Y';

Hi flexman,

Congrats for the small and tidy module :) See below my comments:

- you should use format_date() Drupal core function instead of date(). format_date takes in consideration the site timezone and the current language. It's a drupal way to format dates.
- it's a recommended to use $delta in the hook_block_configure - see the example hook_block_configure
- have you try to find other modules which could achieve the same functionality? Drupal community encourages collaboration over competition. What are the benefits of your project compared with clock project?
- also I've seen the core reviewers to reject projects with less than 200 rows of code...