The 'aggregator_feed' entity type doesn't have a UUID field

1. do we do update functions anymore?
2. what about feed items?

a ha. i see, thanks!
i guess UUID for items doesnt make sense indeed.
lets do it then

Tagging for reroll.

Reroll attached.

update_2002 taken from something else.

Failed in views_ui test? Re-queue for test after a while? Suggestions?

FATAL Drupal\views_ui\Tests\OverrideDisplaysTest: test runner returned a non-zero error code (1)

Lets ask for a retest. probably a random failure

10: 2149841-10-give-aggregator_feed-entity-uuid.patch queued for re-testing.

Thanks @drastik!

+++ b/core/modules/aggregator/lib/Drupal/aggregator/Entity/Feed.php
@@ -35,6 +35,7 @@
+ *     "uuid" = "uuid"

Super duper nitpick but this line in the annotation should (for coding standards) have a trailing comma now right? Now that #2138867: Allow dangling commas in annotations is in.

For @Cottser Mr. nit-picky (I agree).

Also including another place:

+++ b/core/modules/aggregator/lib/Drupal/aggregator/Entity/Feed.php
@@ -27,7 +27,7 @@
  *     "form" = {
  *       "default" = "Drupal\aggregator\FeedFormController",
  *       "delete" = "Drupal\aggregator\Form\FeedDeleteForm",
- *       "remove_items" = "Drupal\aggregator\Form\FeedItemsRemoveForm"
+ *       "remove_items" = "Drupal\aggregator\Form\FeedItemsRemoveForm",

lol.

15: 2149841-15-give-aggregator_feed-entity-uuid.patch queued for re-testing.

+++ b/core/modules/aggregator/lib/Drupal/aggregator/Entity/Feed.php
@@ -27,7 +27,7 @@
  *     "form" = {
  *       "default" = "Drupal\aggregator\FeedFormController",
  *       "delete" = "Drupal\aggregator\Form\FeedDeleteForm",
- *       "remove_items" = "Drupal\aggregator\Form\FeedItemsRemoveForm"
+ *       "remove_items" = "Drupal\aggregator\Form\FeedItemsRemoveForm",

That's actually a bit out of scope here since we otherwise wouldn't be changing that hunk. I know it's in the same file and your intentions are good, but patches can quickly get out of hand when we start fixing all the bad things in a file :)

Yes, for the future, only fix coding styles in lines that you change yourself. But let's get this in now :)

15: 2149841-15-give-aggregator_feed-entity-uuid.patch queued for re-testing.

#2168011: Remove all 7.x to 8.x update hooks and disallow updates from the previous major version is almost ready and conflicts with this.

In this particular case, the migration should not have to change at all, so I think we could just remove the update hook from here altogether.

I added a note about it at https://groups.drupal.org/node/394338.

I'm not sure what you want here.

Remove all other update hooks except adding the uuid column?

No, just not add any now update hooks here. Re-roll the patch without those two functions and we should be good to go.

hook_schema() does for new installations, which is enough. Migrate will just put stuff in the final schema, through the entity API, which will automatically create a UUID. And we don't need to support a minor upgrade path before beta.

Like this. :)

30: aggregator-feed-2149841-30.patch queued for re-testing.

Committed and pushed to 8.x, but it's surprising to me that this is not part of ContentEntityInterface or whatever, to prevent any other content entities from making this mistake. Is that being handled in another issue, or?