[D7] News Archive

Link to the project page and git clone command are missing in the issue summary, please add them.

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Hi There,

Thanks for committing your module, here's my review.

- Please add dependency of date module, as it doesn't work without it.
- Please check the Drupal coding standards. It doesn't seem like you followed them. http://pareview.sh/pareview/httpgitdrupalorgsandboxsu8z3r02072793git
- Use the correct prefix for functions. They should start with you module name.
- You're using a lot of queries. It is preferred to use Drupal's api's. Please use the date api or field api where possible.
- Think about sanitising text. https://drupal.org/node/28984. I don't see any sanitising before printing it to the screen, so please check that.
- Please check the function: _news_archive_get_content_type_fields. It's not showing any date fields in my case. I do have content types with date fields, but they are not showing.
- Why is you admin file in a seperate module folder? Am I missing something?
- Using the news_archive block creates an error:
PDOException: SQLSTATE[42S02]: Base table or view not found: 1146 Table 'test.field_data_' doesn't exist: SELECT DISTINCT Year(_value) FROM {field_data_} WHERE entity_id = 1 ORDER BY Year(_value) DESC; Array ( ) in _get_current_node_info() (line 212 of /sites/all/modules/news_archive/news_archive.module).
- Can you please explain what are the advantages of this module over just building a view. One could easily create a view (maybe export it as a feature) and obtain the same functionality. What is this module adding to a standard news archive view?

Good luck, keep up the good work!

Closing due to lack of activity. Feel free to reopen if you are still working on this application (see also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.