[D7] Save Redirect On Delete

Hi

I've tried to test your module, was unable to get it to work however, following the steps detailed in the readme file:

1. Created a page @ url /deleted
2. Set the Default Pattern After Delete to [site:url]/deleted
3. Created an alias for an existing node to /testthis
4. Deleted this node, having checked the alias worked.
5. /testthis alias now just goes to page not found, rather than [site:url]/deleted as per expected behaviour.

Also, pareview comes up with issues:
http://pareview.sh/pareview/httpgitdrupalorgsandboxgauravgoyal2155137git...

Thank you

Michel

Hi Gaurav. Goyal,

http://pareview.sh/pareview/httpgitdrupalorgsandboxgauravgoyal2155137git... is still showing a list of errors.

./save_redirect_on_delete.module: all functions should be prefixed with your module/theme name to avoid name clashes. See http://drupal.org/node/318#naming

function path_pattern_after_entity_delete($entity, $type = '') {
function give_alias($type, $entity) {
function save_delete_redirect($source, $dest) {
function is_redirect_exists($alias) {
function delete_redirect($redirect) {

Coder Sniffer has found some issues with your code (please check the Drupal coding standards).
FILE: ...var/www/drupal-7-pareview/pareview_temp/save_redirect_on_delete.install

--------------------------------------------------------------------------------
FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
9 | ERROR | Function comment short description must be on a single line,
| | further text should be a separate paragraph
--------------------------------------------------------------------------------

FILE: /var/www/drupal-7-pareview/pareview_temp/save_redirect_on_delete.module

--------------------------------------------------------------------------------
FOUND 3 ERROR(S) AFFECTING 3 LINE(S)
--------------------------------------------------------------------------------
59 | ERROR | Return comment must be on the next line
142 | ERROR | Return comment must be on the next line
232 | ERROR | Return comment must be on the next line
--------------------------------------------------------------------------------

Hi Gaurav. Goyal,

Upon manual review,

1 - I see the repeated code/same code for both hook_node_delete and hook_user_delete, My suggestion is to use the hook_entity_delete where Act on entities when deleted (i.e. Node, user, comment).

function save_redirect_on_delete_node_delete($node) {
  $type = 'node';
  $alias = give_alias($type, $node);
  $dest_value = path_pattern_after_entity_delete($node, $type);
  // If Alias is empty then return.
  if (empty($alias)) {
    return;
  }
  save_delete_redirect($alias, $dest_value);
}

/**
 * On user delete its url alias is redirected to user defined path.
 *
 * Implements hook_user_delete().
 */
function save_redirect_on_delete_user_delete($account) {
  $type = 'user';
  $alias = give_alias($type, $account);
  $dest_value = path_pattern_after_entity_delete($account, $type);
  // If Alias is empty then return.
  if (empty($alias)) {
    return;
  }
  save_delete_redirect($alias, $dest_value);
}

2 - Unsetting a persistent variable on hook_unistall, deleting the variable directly from the database are not recommended because code doesn't unsets the data from the $conf global variable see

function save_redirect_on_delete_uninstall() {
  // Delete all the pathauto variables and then clear the variable cache.
  db_delete('variable')
   ->condition('name', 'redirect_%_delete_pattern', 'LIKE')
   ->execute();
  cache_clear_all('variables', 'cache');
}

You should use variable_del where it unset the data from $conf global variable.

If you are trying to get git access to publish your project, you need to post this issue in the Drupal.org Project applications queue at https://drupal.org/project/issues/projectapplications

Posting this here in your sandbox issue queue will not get your project published.

This is my first review but hope I can provide some useful input.

I created an article called "delete me", deleted it and got redirected as expected.
I then tried to create a basic page called "delete me" however upon trying to save I got stuck in an endless redirection loop. I suspect you need to do some checking to see if the alias already exists when users create new content and alert them of the fact the alias already exists, maybe with an option to delete the old alias or edit the existing one that they are trying to create.

The redirection worked perfectly for all content types and taxonomy terms but I could not get it to work for any file types.

I created a basic page and attached a document (pdf), image (png), audio (mp3) and video (mp4). After deleting the page they were attached to I tried to visit the url to download these files but was not redirected anywhere.
The video, audio and document just displayed a Drupal page not found page, but the image just displayed a "Not Found" message not within a Drupal page (just blank apart from the message).

I've set the status to "Needs Work" as I think the endless redirection loop scenario needs looking at. (Let me know if this is not the right thing to do...)