[D7] Achecker integration

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Pre-define $form in achecker_integration_admin_settings_form as it might give notices in some cases.

Ok sure but yours is achecker_integration_admin_settings_form($form_state).

But the examples you brought up would be achecker_integration_admin_settings_form($form, &$form_state)

Hi Andy

I've gone through the module code, discovered a few minor issues:

1. Even though the README says "This module allows the submission of nodes to the ACHecker validation API via
a node operation on the content page" I couldn't find the option, until disabled the administration_views module. Perhaps this could be highlighted in the README.txt?

2. Didn't seem to get any feedback when I actually performed an Achecker integration scan on my content. There was also no link to the reporting page where I did find the results of the scan. The scan should display a message with the results, from within which you should be able to go to the results page.

3. The links on the error descriptions such as Document does not validate don't work
http://achecker.ca/checkacc.php/checker/suggestion.php?id=232 isn't a valid url

4. The instructions for the tinyMCE plugin says

Extract the archive from ATtutor

There are actually 2 libraries on that page, and you need the second one, the tinyMCE plugin. Also requires WYSIWYG tinyMCE library to be present. Perhaps have a requirement for that itself?

5. Requirements hook doesnt work, still gives an error on the status report page even if you have a valid webservice id. This is probably due to

6. achecker_integration.install
line 58 - $webservice_id = variable_get('achecker_integration_webservice_id2', '');
I think you may have misspelled the variable name, as everything else uses variable_get('achecker_integration_webservice_id', '');

Apart from that the code looks fine.

Thanks

Michel

Hi Andy

Thank you for your module, I have noted a few possible improvements:

In your settings form, achecker_integration_admin_settings_form, you have a field called achecker_integration_webservice_url. This field currently has no validation but some aspects of validation could easily be added (such as using parse_url() to check for a valid url).

In function achecker_integration_scan, you have a watchdog error for DOMDocument, it may be useful to add a link to the PHP DOMDocument page here. Similarly when you watchdog for a failed REST request maybe a link to the settings page would be helpful.

Best of luck with your module,

Alastair

manual review:

1. achecker_integration_scan(): class_exists('DOMDocument') should be done in hook_requirements() once, not here.
2. achecker_integration_scan(): what is the $session parameter? Please add @param docs.
3. achecker_integration_wysiwyg_wysiwyg_plugin(): hard-coding sites/all/libraries could be a problem for distributions that use something like "profiles/recruiter/libraries", right?

But otherwise looks RTBC to me. Removing review bonus tag, you can add it again if you have done another 3 reviews of other projects.

Assigning to MiSc as he might have time to take a final look at this.

no objections for more than a week, so ...

Thanks for your contribution, andystone78!

I updated your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.