Tools to monitor the code of your Drupal site. Initial release includes a PHPLOC submodule. Each tracked project has PHPLOC executed against its full git repo history and all data stored.

https://drupal.org/sandbox/nateswart/2159455

git clone --branch 7.x-1.x http://git.drupal.org/sandbox/nateswart/2159455.git

Comments

abhishek-anand’s picture

abhishek-anand commented

Hi,

Kindly correct errors reported by automated review tool http://pareview.sh/pareview/httpgitdrupalorgsandboxnateswart2159455git

Thanks,
Abhishek

Anonymous’s picture

Anonymous (not verified) commented

I have addressed the issues reported by the tool. The remaining items listed I believe to be false positives (naming guidelines, the module is in fact prefixing all of those functions).

Thanks!
-Nate

grabimo’s picture

grabimo commented

can you update the git link git clone --branch 7.x-1.x nateswart@git.drupal.org:sandbox/nateswart/2159455.git? Your user name should not be here.

Also, I was educated that it would be a good practice to reuse package instead of creating a new one in project_qa.info. Checkout the guideline here: https://drupal.org/node/542202

PA robot’s picture

PA robot commented

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Anonymous’s picture

Anonymous (not verified) commented
Issue summary: View changes
Anonymous’s picture

Anonymous (not verified) commented

Done and done. Thanks for the feedback!

RavindraSingh’s picture

RavindraSingh commented

@nateswart, ProjectQA might be good module. but in structure (Directory Structure and Naming convention), well descriptive issue summary may be helpful for publish it as a full project.

Still http://pareview.sh/pareview/httpgitdrupalorgsandboxnateswart2159455git is showing many things needs to be tweak.

fix all the errors and really interested to see on d.o.

Anonymous’s picture

Anonymous (not verified) commented

Perhaps pareview was having a caching issue? The link you specified showed a series of issues that I fixed based on previous feedback. I refreshed the page and now it is showing appropriately.

There are still a few issues listed, but they appear to be false positives. For example:

---
./phploc/views/phploc_views/phploc_views.views_default.inc: all functions should be prefixed with your module/theme name to avoid name clashes. See http://drupal.org/node/318#naming

function phploc_views_views_default_views() {
---

The name of that (sub) module is phploc_views ... so it is in fact already prefixed appropriately, unless I'm misunderstanding what it is saying.

I do have a 3-part blog series written and am finishing up a screencast to help demonstrate usage of this module for when it is officially "released".

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Needs review » Needs work

You should not have a submodule with a completely different name in the repository. Either rename it or move it to its own repository.

Anonymous’s picture

Anonymous (not verified) commented

Happy to report that I refactored the naming and now http://pareview.sh/pareview/httpgitdrupalorgsandboxnateswart2159455git reports entirely clean.

Anonymous’s picture

Anonymous (not verified) commented
Status: Needs work » Needs review
dan.ashdown’s picture

dan.ashdown commented
Status: Needs review » Needs work

Hi nateswart,

This looks like it could be quite useful thanks for writing. There's a lot of code there :)

No problems reported by pareview.

Upon manual review I found the following issues:

  1. Your module description is a little esoteric, please explain the functionality the module offers
  2. Within projectqa_get_filepath() you have hard coded a server path and left a "todo" comment there. You're not meant to submit modules that are still in development. I.e. they should only be submitted when you deem them ready to ship.
  3. Another "todo" comment in projectqa_walk_repo().
  4. For simple database queries such as the one in projectqa_walk_repo(), you should use db_query() instead of db_select(), for simple queries where you're not conditionally adding conditions etc. See: https://drupal.org/node/310075
  5. projectqa_process_git_revisions() would benefit from some in line comments.
  6. 3 more "todo" comments in projectqa_process_git_tags().
  7. projectqa_get_commit_id() db_select() would be better as a db_query() as above.
  8. Commented out debugging code in projectqa_phploc_eval_gitcommit() should be removed.
Anonymous’s picture

Anonymous (not verified) commented
Status: Needs work » Needs review

Great feedback, thank you!

1. Updated
2. Was intended for future work so I didn't forget, but made it more flexible with a variable_get and removed the todo.
3. This todo is def a personal note for future enhancements I'd like to add. I've moved it into a feature request of my issue queue and removed from code.
4. Changed to db_query
5. Done
6. More future features/development ideas. Removed (harmless) for now, and converted to feature request tickets.
7. Changed to db_query
8. Done

dstol’s picture

dstol
Primary language English
commented
Status: Needs review » Fixed

Go forth!

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented

@dstol: thanks for helping out here!

Our usual process is to get project applications to RTBC before we approve them, see the workflow: https://drupal.org/node/532400

I added you to the list of code review administrators: https://groups.drupal.org/node/142454

And usually we paste help text from https://groups.drupal.org/node/184389 upon approval:

Thanks for your contribution, nateswart!

dstol updated your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.