Remove calls to deprecated global $user wherever possible (outside bootstrap and authentication)

testbot activate?

@xjm I'm not to sure on the approach to do them all at once. I know what you are trying to do but these are deceivingly tricky.
A lot of tests don't work upon conversion and doesn't seem to be an API for setting the current_user.

But here's an attempt to see what testbot says.
Didn't convert them where they needed current_user set and some tests.
Didn't convert session.inc, bootstrap.inc, AuthenticationManager, AuthenticationEnhancer, TestBase, WebTestBase, user module and a few tests.

@xjm ok, just wanted to make sure you're looped in to what's happening. Here is the same patch split in half to try to narrow down what is causing the failed install.

part 2 split in 2.

Ok think it's entity controller

diff --git a/core/lib/Drupal/Core/Entity/EntityAccessController.php b/core/lib/Drupal/Core/Entity/EntityAccessController.php
index f18cd2c..9285422 100644
--- a/core/lib/Drupal/Core/Entity/EntityAccessController.php
+++ b/core/lib/Drupal/Core/Entity/EntityAccessController.php
@@ -276,7 +276,7 @@ protected function checkCreateAccess(AccountInterface $account, array $context,
    */
   protected function prepareUser(AccountInterface $account = NULL) {
     if (!$account) {
-      $account = $GLOBALS['user'];
+      $account = \Drupal::currentUser();
     }
     return $account;
   }

guessed wrong i guess

ok both

hmm needs narrowing further

cookie!

cookie and entityaccesscontroller removed...

Fine, all of patch https://drupal.org/files/issues/2163203-7-global-user-part2-2-2.patch removed.

hmm must have buggered that patch.

Ok this should get rid of the password reset errors.

Ok green! That leaves the following out:

global $user:

core/includes/bootstrap.inc
core/includes/session.inc
core/lib/Drupal/Core/Authentication/AuthenticationManager.php
core/lib/Drupal/Core/Authentication/Provider/Cookie.php
core/lib/Drupal/Core/Form/FormBuilder.php
core/lib/Drupal/Core/Routing/Enhancer/AuthenticationEnhancer.php
core/modules/simpletest/lib/Drupal/simpletest/TestBase.php
core/modules/system/lib/Drupal/system/Tests/Common/FormatDateTest.php
core/modules/system/lib/Drupal/system/Tests/Datetime/DrupalDateTimeTest.php
core/modules/system/lib/Drupal/system/Tests/Entity/EntityAccessTest.php
core/modules/system/lib/Drupal/system/Tests/System/TokenReplaceTest.php
core/modules/user/user.module
core/modules/user/user.pages.inc
core/modules/user/lib/Drupal/user/Tests/Views/ArgumentDefaultTest.php

$GLOBALS['user']

core/includes/common.inc
core/lib/Drupal/Core/Entity/EntityAccessController.php
core/lib/Drupal/Core/Routing/Enhancer/AuthenticationEnhancer.php
core/modules/entity_reference/lib/Drupal/entity_reference/Tests/EntityReferenceSelectionSortTest.php:
core/modules/history/lib/Drupal/history/Tests/Views/HistoryTimestampTest.php
core/modules/simpletest/lib/Drupal/simpletest/TestBase.php
core/modules/simpletest/lib/Drupal/simpletest/WebTestBase.php
core/scripts/generate-d7-content.sh

Most of which are needing a way to set the current user(which may need a container?).

Pushing the envelope a bit, a few more added from user.module that I think can be safely added.

Ok here's a patch for each of rest split by file. I made up a wild guess on how to set the current user...
\Drupal::getContainer()->set('current_user', drupal_anonymous_user());

This is an attempt to weed out any other low hanging fruit from the rest of them.

Did a little test and seems to show promise for this way of setting the user in tests at least:

Debug tests:

  $account = $this->drupalCreateUser();
    debug($account->id());
    debug('expect 1');
    debug($GLOBALS['user']->id());
    debug(\Drupal::currentUser()->id());
    debug($this->container->get('current_user')->id());

    \Drupal::getContainer()->set('current_user', drupal_anonymous_user());
    debug('expect 0');
    debug($GLOBALS['user']->id());
    debug(\Drupal::currentUser()->id());
    debug($this->container->get('current_user')->id());


    $this->container->set('current_user', $account);
    debug('expect 2');
    debug($GLOBALS['user']->id());
    debug(\Drupal::currentUser()->id());
    debug($this->container->get('current_user')->id());

Results:

'2'

	Debug	TokenReplaceTest.php	33	Drupal\system\Tests\System\TokenReplaceTest->testTokenReplacement()	Debug

'expect 1'

	Debug	TokenReplaceTest.php	34	Drupal\system\Tests\System\TokenReplaceTest->testTokenReplacement()	Debug

'1'

	Debug	TokenReplaceTest.php	35	Drupal\system\Tests\System\TokenReplaceTest->testTokenReplacement()	Debug

'1'

	Debug	TokenReplaceTest.php	36	Drupal\system\Tests\System\TokenReplaceTest->testTokenReplacement()	Debug

'1'

	Debug	TokenReplaceTest.php	37	Drupal\system\Tests\System\TokenReplaceTest->testTokenReplacement()	Debug

'expect 0'

	Debug	TokenReplaceTest.php	40	Drupal\system\Tests\System\TokenReplaceTest->testTokenReplacement()	Debug

'1'

	Debug	TokenReplaceTest.php	41	Drupal\system\Tests\System\TokenReplaceTest->testTokenReplacement()	Debug

0

	Debug	TokenReplaceTest.php	42	Drupal\system\Tests\System\TokenReplaceTest->testTokenReplacement()	Debug

0

	Debug	TokenReplaceTest.php	43	Drupal\system\Tests\System\TokenReplaceTest->testTokenReplacement()	Debug

'expect 2'

	Debug	TokenReplaceTest.php	47	Drupal\system\Tests\System\TokenReplaceTest->testTokenReplacement()	Debug

'1'

	Debug	TokenReplaceTest.php	48	Drupal\system\Tests\System\TokenReplaceTest->testTokenReplacement()	Debug

'2'

	Debug	TokenReplaceTest.php	49	Drupal\system\Tests\System\TokenReplaceTest->testTokenReplacement()	Debug

'2'

Rolled in some of the ones I think are safe.

These are the remaining files that didn't get patched (see remaining.txt) for interdiff between #38 and #61:

+++ b/core/includes/bootstrap.inc
+++ b/core/includes/session.inc
+++ b/core/lib/Drupal/Core/Authentication/AuthenticationManager.php
+++ b/core/lib/Drupal/Core/Authentication/Provider/Cookie.php
+++ b/core/lib/Drupal/Core/Entity/EntityAccessController.php
+++ b/core/lib/Drupal/Core/Form/FormBuilder.php
+++ b/core/lib/Drupal/Core/Routing/Enhancer/AuthenticationEnhancer.php
+++ b/core/modules/entity_reference/lib/Drupal/entity_reference/Tests/EntityReferenceSelectionSortTest.php
+++ b/core/modules/history/lib/Drupal/history/Tests/Views/HistoryTimestampTest.php
+++ b/core/modules/simpletest/lib/Drupal/simpletest/TestBase.php
+++ b/core/modules/simpletest/lib/Drupal/simpletest/WebTestBase.php
+++ b/core/modules/system/lib/Drupal/system/Tests/Common/FormatDateTest.php
+++ b/core/modules/system/lib/Drupal/system/Tests/Datetime/DrupalDateTimeTest.php
+++ b/core/modules/system/lib/Drupal/system/Tests/Entity/EntityAccessTest.php
+++ b/core/modules/user/lib/Drupal/user/Tests/Views/ArgumentDefaultTest.php
+++ b/core/modules/user/user.module
+++ b/core/modules/user/user.pages.inc
+++  b/core/scripts/generate-d7-content.sh

Re-roll.

@valthebald the title isn't wrong, @xjm repurposed this issue in #6 Just needs a new issue summary too.

Re-rolled.

Re-roll

back to rtbc with re-roll.

@alexpott let me know if you want another re-roll and when you plan to commit this, if ever. I'll work on other things in the meanwhile. Ping me on IRC.

So happy to see this one getting in! Going to open another for the remaining from #62 and others that have sneaked in since.