[D7] Ajaxable forms

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Follow https://drupal.org/comment/8254889#comment-8254889 for moving from a master to a major version branch.

Hey alexsergivan,

I'm sorry this is a half baked review as I can only browse the code. I'm currently not at home and won't be for some time.

Your including some JavaScript & CSS via a page preprocess function. Consider all specific JS & CSS attachable via your form alter implementation. Please have a look at https://api.drupal.org/api/drupal/developer!topics!forms_api_reference.h...

Finding the form submit button is problematic as in theory it could be in any number of places, have a gander at https://api.drupal.org/api/drupal/includes!common.inc/function/drupal_ar...
This is of course only really an issue for user made/ contrib module forms.

Your Ajax callback is a little strange however I put this down to having unknown form errors & forcing them to trigger? Still you should be able to return your system messages as such,

  $message = drupal_set_message(t('Some message text'), 'status');
  $commands = array();
  $commands[] = ajax_command_prepend('div#messages', theme('status_messages', $message));
  return array('#type' => 'ajax', '#commands' => $commands);

Cheers,

Remove master branch, it's unnecessary as you create drupal version specific branches.

Manual review:

Please fix these issues first:
http://git.drupal.org/sandbox/ALEXANDROSS/2149773.git

No application blocking reason given, so this still needs review.

Hi Alexsergivan,

I feel it's duplicate module. Can you explain me how this module is different from https://drupal.org/project/asaf module ?

Cheers,
Anil Sagar

Closing due to lack of activity. Feel free to reopen if you are still working on this application (see also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.