[D7] ReevooMark

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

PAreview.sh found only one issue:

http://pareview.sh/pareview/httpgitdrupalorgsandboxpeterc2090905git

FILE: /var/www/drupal-7-pareview/pareview_temp/reevoomark.module
--------------------------------------------------------------------------------
FOUND 0 ERROR(S) AND 1 WARNING(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
334 | WARNING | All constants defined by a module must be prefixed with the
| | module's name, expected "REEVOOMARK_CURLOPT_TIMEOUT_MS" but
| | found "CURLOPT_TIMEOUT_MS"
--------------------------------------------------------------------------------

Other than that I think you forgot to add ReevooMarkServiceDocument.php to reevomark.info?

It is recommendable to delete the Master branch

Dear theapi,

Some variables set by this module are not removed when uninstalling it.
I found the two variables (reevoomark_css_best_offers and reevoomark_css_embedded_reviews) still present in the database even after uninstalling this module.

I think you should include the following two lines in reevoomark_uninstall() function:

variable_del('reevoomark_css_best_offers');
variable_del('reevoomark_css_embedded_reviews');

Cheers!!!

Please justify setting to rtbc. For instance, a report that the code works as expected would be very useful.

The module does work. Very handy for getting Reevoo reviews on the page.

This module has been reviewed and tested to work as expected according to integration documents by Reevoo.

Thanks for your contribution, theapi!

I updated your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks to the dedicated reviewers as well.