Convert position selectors to be compatible with with jQuery native-API selector

using :even and :odd do not take us much closer to not using sizzle. The changes should be:

:eq -> $("your-pure-css-selector").eq(index)
:gt(index) -> $("your-pure-css-selector").slice(index)
:lt(index) -> $("your-pure-css-selector").slice(0, index)

OK.

:even -> .filter(":even")
:odd ->.filter(":odd")

We can leave those alone, they'll get removed eventually.

:first -> .first()
:last -> .last()

so something like:

-    this.$textElement = this.$el.find('.field-item:first');
+    this.$textElement = this.$el.find('.field-item').first();

Also we don't touch files in the assets/vendor folder, it's not ours.

And you should really use JSHint, you have syntax errors that makes the file completely useless :) https://drupal.org/node/1972428

1. +++ b/core/misc/tabledrag.js
   @@ -310,18 +310,18 @@ Drupal.tableDrag.prototype.makeDraggable = function (item) {
   -  var $indentationLast = $item.find('td:first .indentation:last');
   +  var $indentationLast = $item.find('td .indentation').last();
   

   Missing :first

2. +++ b/core/misc/vertical-tabs.js
   @@ -102,7 +102,7 @@ Drupal.verticalTab = function (settings) {
   +      $('.vertical-tabs-pane').find('input,button,textarea,select').filter(':visible:enabled').first().trigger('focus');
   

   can we add space after comma

- Fixed mismatch selectors
- :first -> eq(0)
- :last -> eq(-1)
- dropped one :input fix, we fix it in another issue thread.

Patch applies cleanly and fixes the issue. I have verified that there are no more pending selectors to search and replace.

This is a reroll because the indentation standard changed for JavaScript files. No need for commit credit because of this reroll.

+++ b/core/modules/views_ui/js/views-admin.js
@@ -818,7 +816,7 @@
-      function changeDefaultWidget(event) {
+      function changeDefaultWidget (event) {

@@ -830,6 +828,7 @@
+

These changes are not present in RTBC patch. This is not a functional change but I think we should revert it because it is not related.

There's no confirmation on here that someone's manually tested the js that gets touched.

Having a go on this at DrupalSouth 2014

Table drag works a treat, thanks.

What should I be looking for when doing manual testing of this patch?

I have converted some of the position selectors to be compatible with with jQuery native-API selector

As nod_ said "...we don't touch files in the assets/vendor folder, it's not ours."

And, definitely, patch #10 needs re-roll + changes suggested in #11

Reroll of patch #10 and the changes suggested in #11.

patch applies.

Please drop all spacing changes from this patch, my mistake for introducing them in the first place.

We already fixed the spacing issues in another issue (also be sure to run eslint when you make a patch to be sure you conform to our JS coding standards).

As mentioned dropping all the spacing changes and retaining type selectors changes. Please review

I've updated the patch, files had been updated since patch created.

Totally my fault but needs reroll. Sorry.

Rerolling.

Rerolled.

Do we want to use :not selector or jQuery .not?

The case is:
var $firstTab = this.details.siblings('.vertical-tabs__pane').not('.vertical-tab--hidden').eq(0);
vs
var $firstTab = this.details.siblings('.vertical-tabs__pane:not(.vertical-tab--hidden)').eq(0);

I guess that :not will be faster with "proper" browsers.

Yep that's CSS3 stuff since it's a simple selector inside the :not.

So yes, please use :not()

( edit ) patch already does it, great :)

Block admin works
Contextual works
Editor works
Tabledrag works (keyboard and mouse) (on display mode (with group))
Responsive table works
Text summary works
Tour works
Vertical tabs works
Views admin works.

All good, thanks!

This is a non disruptive change to javascript - therefore permitted during the beta. Committed 22ef398 and pushed to 8.0.x. Thanks!

Ouch, broken some features: #2489826: tabledrag is broken