[D7] SIPml5 JavaScript library module for DruCall and WebRTC

Multiple Applications

It appears that there have been multiple project applications opened under your username:

Project 1: http://drupal.org/node/1928458

Project 2: http://drupal.org/node/1949616

As successful completion of the project application process results in the applicant being granted the 'Create Full Projects' permission, there is no need to take multiple applications through the process. Once the first application has been successfully approved, then the applicant can promote other projects without review. Because of this, posting multiple applications is not necessary, and results in additional workload for reviewers ... which in turn results in longer wait times for everyone in the queue. With this in mind, your secondary applications have been marked as 'closed(duplicate)', with only one application left open (chosen at random).

If you prefer that we proceed through this review process with a different application than the one which was left open, then feel free to close the 'open' application as a duplicate, and re-open one of the project applications which had been closed.

I'm a robot and this is an automated message from Project Applications Scraper.

There are some errors reported by automated review tools, did you already check them? See http://ventral.org/pareview/httpgitdrupalorgsandboxpocock1949598git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

IMHO the module here is more straight forward to use it as project application. In the other hand PA robot closed the other issue #1928458-8: DruCall - WebRTC support for Drupal, so I let's try to make this process happen.

There is no so much code to review here, so the only suggestion I have is to document the hook_libraries_info() implementation. Please make that change and mark the issue to needs review.

For other reviewers: Notice there a good amount of Daniel effort on the related issue, and he has been following all the suggestions we have mentioned to him. Also, I personally consider that the work he is doing can impact a lot of people if the modules end up in stable releases.

Closing due to lack of activity. Feel free to reopen if you are still working on this application.

I'm a robot and this is an automated message from Project Applications Scraper.

Hi pocock,

I tried your module and it just seems to need a hook_requirements() to verify if the necessary library files are actually in the file system. You can add the hook in a new file: sipml5.install.

Also, you should remove COPYNIG.txt, as drupal.org packaging will automatically add a LICENSE.txt file (GPLv2). Attribution and description of external libraries copyright can be added to your README.

Other than that, just be sure to pass PAReview:

• Files must end in a single new line.
• Add a file comment. See https://drupal.org/node/1354#file.

I understand this library is a dependency of another module in your sandbox. I'll try to set it up, and comment when I get it running as well.

Cheers!

  This module wrapper for SIPml5 is licensed under the terms of the
  GPLv2 or later.  Copyright (C) 2013 Daniel Pocock http://danielpocock.com

This needs to be removed from the README.txt. See https://drupal.org/licensing/faq#q7

dev-notes.txt file should be deleted.

Whitespace and other findings from PA Review. http://pareview.sh/pareview/httpgitdrupalorgsandboxpocock1949598git

Version 7.x-1.x should be included in your .info file.

Good use of hook_requirements().

This project is too short to approve you as git vetted user. We are currently discussing how much code we need, but everything with less than 120 lines of code or less than 5 functions cannot be seriously reviewed. However, we can promote this single project manually to a full project for you. If you wish to have this manually promoted, after fixing the above mentioned issues please move back to needs review.

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.

Automated Review

n/a

Manual Review

Individual user account

Yes: Follows the guidelines for individual user accounts.

No duplication

Yes: Does not cause module duplication and/or fragmentation.

Master Branch

Yes: Follows the guidelines for master branch.

Licensing

Yes: Follows the licensing requirements.

3rd party code

Yes: Follows the guidelines for 3rd party code.

README.txt/README.md

No: Does not fully follow the guidelines for in-project documentation and/or the README Template.

Code long/complex enough for review

No: Does not follow the guidelines for project length and complexity.

Secure code

Yes: Meets the security requirements.

Coding style & Drupal API usage

List of indentified issues in no particular order.

1. re my feedback in #10, version information shouldn't be included.
   

   Version 7.x-1.x should be included in your .info file.

The starred items (*) are fairly big issues and warrant going back to Needs Work. Items marked with a plus sign (+) are important and should be addressed before a stable project release. The rest of the comments in the code walkthrough are recommendations.

If added, please don't remove the security tag, we keep that for statistics and to show examples of security problems.

This review uses the Project Application Review Template.

pocock,

I updated your account so you can promote sipml5 and more to to "full" projects. .

Here are some documents I recommend to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your earnestness through this review process. Good luck continuing your work on WebRTC and VoIP!

Thanks also to heddn, Arlina, and marvil07 for your helpful comments.