Closed (fixed)
Project:
Image javascript crop
Version:
7.x-1.x-dev
Component:
Javascript
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
13 Dec 2011 at 08:09 UTC
Updated:
25 Mar 2012 at 19:50 UTC
Jump to comment: Most recent
Comments
Comment #1
nils.destoop commentedWhat version of media are you using? I justed tested with 7.x-2.x-dev (7 dec) and everything looks working.
I create new article node, select an image with the mediafield selector, and the button shows up.
Comment #2
nils.destoop commentedApparently you are using the multimedia asset. I tested using the image field as a media selector widget.
Comment #3
nils.destoop commentedThis problem should now be fixed on dev.
Comment #4
slashrsm commentedI tested this and I keep having the same problem with the latest code.
Comment #5
nils.destoop commentedEverything works here.
When you view the source from the node add page. The js should be in following order:
Is this correct. If it is. Can you check with firebug, if
Comment #6
slashrsm commentedButton is there, but is hidden. If I un-hide it and click on it I get the following error:
Screenshoot: http://awesomescreenshot.com/039q7k6de
I am using Media 7.x-1.0-rc2. This is currently the only recommended version of Media.
Comment #7
jisuo commentedI have problem with this as well. I use Media 7.x-2.0-unstable3 and Image javascript crop 7.x-1.0-dev.
This is on a Image field on a custom content type.
It works if I use the Image widget on the Image field, but if I use the Media selector widget the crop-button has display: none and if you unhide it and try to use it you get the same error message as in post #6 ("The image to crop was not found.").
Comment #8
nils.destoop commentedThis should be fixed now.
Comment #9
slashrsm commentedI tried on 7.x-1.x and the bug remains there.
It would be much easier to test new code, if you'd upload patch to the issue and put it into a review process. It would be much easier for us to provide good feedback this way.
Comment #10
nils.destoop commentedPatch can be found here: http://drupalcode.org/project/imagecrop.git/patch/60e0387
Before this patch, things where not working on node/add.
Can you show me a screenshot of your fields on the node form. Then i'll create the same content type.
The problem is that media doesn't have a js hook. So to do something when an image changes, i have to take over all his code.
Because of this, it's very important that imagecrops js is loaded after the js from media.
Comment #11
andykisaragi commentedHI, I am having the same problem on node/add with latest dev versions of media and imagecrop - works for an image with image widget, but not media file selector widget. I can't see that there's any js on the page for imagecrop.
Comment #12
bryancasler commentedConfirming the problem with the latest dev when using the media widget. Also, there is no cropping button being hidden on the page, it's just not there.
Comment #13
nils.destoop commentedConfirming the bug. Media module changed the field structure. Busy with implementing this.
Media 7.1 will need a small patch to keep working with imagecrop. I'll post the patch here.
They introduced a javascript event in 7.2, this way, i don't need to overwrite media's code.
Comment #14
nils.destoop commentedI just committed a big change for media support to the dev. A patch can be found at: http://drupalcode.org/project/imagecrop.git/patch/320dfd1313d9b97025bfae...
This fixed all issues for me on both media 1.x and 2.x.
Comment #15
bryancasler commentedI can confirm this is fixed
Comment #16
slashrsm commentedConfirmed.
Comment #16.0
slashrsm commentedFixed a typo.
Comment #17
fvictoire commentedIs the patch in the stable release of the module Media (Media 7.x-1.4) ?
I have reproduced the bug with this release of Media (release of Image Javascript crop is 7.x.1.0-rc3).
Thanks for the answer.
Comment #18
ianthomas_uk7.x.1.0-rc3 is very out of date. As it says on the project homepage, you should use the -dev release for now.
Comment #19
fvictoire commentedHi,
thanks you for the answer.
I have the crop button with the dev module of Image Javascript crop (7.x-1.0-rc3+68-dev), but when I click on the save button after cropping this error appears :
SQLSTATE[42S22]: Column not found: 1054 Unknown column 'rotation' in 'field list'
I can not save the new cropped image.
Comment #20
ianthomas_ukIs your database up to date? If it is, please can you open a new issue for that error.
Comment #21
fvictoire commentedIt was just a problem of database update.
Thanks.