[D7] Profile URL

Hi yashsharma01,

I have been reviewing your module and it's well coded, you can see it here

The module funcionality is very simple and can be implemented with core fields and url aliases. This modules automates url aliases creation but it can be implemented with automatic path module tokens

Cheers!

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Thanks yashsharma01,

I have reviewed your module and it's is well coded and documented.
This is very simple but very useful module for the user to create direct profile link, Even we can create user profile url by drupal core url alias but, it is difficult for normal users.
Thanks for contributing to community.

Thanks,
Santosh

Nit-picky, but the README file had various spacing between elements.

Patch attached to clean it up.

Hi yashsharma01,

Your module looks quite convincing, here's a little suggestion that you can implement.

.module file line 47
Change message from 'Already exist this url!' to 'This url already exists. Please choose another one !'

Best of luck :)..

I see a problem with the way you are doing commits.

This page should show your drupal.org user as the committer:
https://drupal.org/node/2178139/commits

Instead it shows 'by root'.

See this page for more information about git identity:
https://drupal.org/node/1022156

You can check if you are properly identifying yourself to get with:
git config -l

Also, you should grab Dreditor for easily making your commit messages.
https://dreditor.org/
This will also allow you an easy way to properly set the --author line in your commit when you receive a patch from an issue queue and commit it.

For example, this commit:
http://drupalcode.org/sandbox/yashsharma01/2178139.git/commit/b24e0b1

Should say:
author: drastik
committer: yashsharma01

Once you have dreditor installed, you'll see a "Create commit message" button just above the comment field on issue queues like this on d.o. Click it, and it will automatically create the commit message like so:

git commit -m "Issue #2178807 by drastik | yashsharma01: [D7] Profile URL." --author="drastik <drastik@433663.no-reply.drupal.org>"

If you identified yourself to git per that link above, and used that commit message, you would have a commit that said author: drastik, committer: yashsharma01 and the message "Issue #2178807 by drastik | yashsharma01: [D7] Profile URL." which would also auto-create a link back to this node when looking @ the commit on drupal.org.

The reasons listed in last comment (#16) are also why you don't see that project listed on your drupal.org profile as a project you commit to:
https://drupal.org/user/263116

Hi yashsharma01,
This is a nice module, i have reviewed but did not get any bug. I think this is ready to release.
Thanks for contribution.
Regards
Debraj

hi yashsharma01,
changing status to RTBC

Review of the 7.x-1.x branch:

• DrupalPractice has found some issues with your code, but could be false positives.
  

  
  FILE: /home/klausi/pareview_temp/profile_url.module
  --------------------------------------------------------------------------------
  FOUND 0 ERROR(S) AND 1 WARNING(S) AFFECTING 1 LINE(S)
  --------------------------------------------------------------------------------
   66 | WARNING | Messages are user facing text and must run through t() for
      |         | translation
  --------------------------------------------------------------------------------
  

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. You have to get a review bonus to get a review from me.

manual review:

1. project page is too short, what does the module do? what profile URL? The profile2 URL https://drupal.org/project/profile2 ? Or the user view page? Please fix your project page according to https://drupal.org/node/997024
2. profile_url_edit_form_validate(): doc block is wrong, see https://drupal.org/node/1354#forms . Same for profile_url_edit_form_submit().
3. "'language' => 'und',": don't use "und", use LANGUAGE_NONE instead.
4. profile_url_edit_form_validate(): that validation is not enough, I can insert "node/1" as profile URL and suddenly my node 1 is not reachable anymore. An attacker could insert arbitrary existing system paths and break your site in an unexpected way. This looks like a security issue to me. I think a menu_get_item() call could help here to determine if a system path exists. And please don't remove the security tag, we keep that for statistics and to show examples of security problems.
5. This project is too short to approve you as git vetted user. We are currently discussing how much code we need, but everything with less than 120 lines of code or less than 5 functions cannot be seriously reviewed. However, we can promote this single project manually to a full project for you.

Removing review bonus tag, you can add it again if you have done another 3 reviews of other projects.

Closing due to lack of activity. Feel free to reopen if you are still working on this application (see also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.