Write tour integration for Extend (Modules) admin page

Looks good to me!

Tour needs tests since we now have #2028535

Adding missing tag.

Added a test to existing patch.

Fixed namespace error.

Accidentally forgot to add the whole patch as well as the tests.

Trying again on the merging the patches.

Note #1918768: Refactor tour module to use routes instead of paths just landed

Re-rolled patch to use the new routing system.

Rerolled tests.

Been ported to routing system, but needs passing tests.

So the issues with the tests are as follows:

• details is a html5 element and the PHP Unit xml helper doesn't recognise html5 (known issue, we need php 5.4 before we can get the version of phpunit that does support it)
• the action links are only present if update module is enabled
• the block chunk same - added block
• the help chunk same - added help

also refactors TourTestBase to

• make it abstract (no tests in there)
• add an adminPermissions property
• create the admin user
• enable seven theme
• fallback to xpath instead of php unit for html5 elements.

Schema fails :-)

Fixes schema fails, having that test in core is neat!

22: extend-tour-2040861.16.patch queued for re-testing.

Some suggestions

1. We should add tour tips for permission and configuration links.
2. We should add some module(perhaps node) specific tour tips.
3. We can add project description related tour tip.

1. +++ b/core/modules/system/config/tour.tour.extend.yml
   @@ -0,0 +1,72 @@
   +    body: 'Use this action link to install a module. There are thousands of contributed modules available for download at Drupal.org.'
   

   Can we make it www.drupal.org?

2. +++ b/core/modules/system/config/tour.tour.extend.yml
   @@ -0,0 +1,72 @@
   +    body: 'This list can get quite long so theres a search field to quickly jump you to the one you are looking for.'
   

   Can we explain search type? e.g. Partial match search or machine name search etc.

3. +++ b/core/modules/system/config/tour.tour.extend.yml
   @@ -0,0 +1,72 @@
   +    body: 'This collapsible group contains the core modules in Drupal. Modules you add will be placed in other groups. You can disable core modules if no other modules depend on them.'
   

   Isn't it a detail group now? In core we also have field and language groups.

4. +++ b/core/modules/system/config/tour.tour.extend.yml
   @@ -0,0 +1,72 @@
   +    body: 'Use the checkbox to enable or disable modules. Remember to save before leaving the page.'
   

   Can't disable now. :P

5. +++ b/core/modules/system/lib/Drupal/system/Tests/Module/ExtendTourTest.php
   @@ -0,0 +1,47 @@
   +    $this->assertTourTips();
   

   This is cool.

6. +++ b/core/modules/tour/lib/Drupal/tour/Tests/TourTestBase.php
   @@ -12,7 +12,38 @@
   +   * @var array
   

   I think this should be string[] now.

7. +++ b/core/modules/tour/lib/Drupal/tour/Tests/TourTestBase.php
   @@ -56,10 +87,24 @@ public function assertTourTips($tips = array()) {
   +          if ($elements == 0) {
   +            // Could be a html5 element that \PHPUnit_Util_XML::cssSelect() does
   +            // not support, fallback to xpath.
   +            $elements = $this->xpath('//*[@id = :id]', array(
   +              ':id' => $tip['data-id'],
   +            ));
   +          }
   

   Please add a @todo to remove this.

We can add tip for uninstall tab as well.

Find attached an attempt for a beefier tour

Some questions:

1. what are the values for the location property. I tried bottom as a value but without succes
2. i wanted to target the td with the description of the first module in the list using data-class: 'system-modules th:first-child td:nth-child(2)'
3. i wanted to present the tips in a "normal" workflow order, instead of in the order in which the elements appear in the page. this results in a rather shaky tour that scrolls a lot up and down the page, if you know what I mean. What is the official opinion on this? should the tour follow a the flow of the page or the recommended user work flow?
4. i keep updating the tour api page (https://drupal.org/developing/api/tour) whenever i find out more about tours, it is always good if others can check/verify changes
5. patch from #16 contains a uuid tour property ("uuid: dd06919e-9c54-49a8-b0e7-bbf7e03d0db7"). what is the purpose of that
6. if a tips is not appearing is there any way to find out why? does a wrong tip definition cause js errors?

1) I think left and right, but will need to consult the joyride documentation
2) Anything that jquery supports should work
3) I think workflow is a good idea
4) No worries
5) Default config should have uuids
6) If the data-class or data-id doesn't find anything, the JavaScript removes the tip from the dom.

Tracking this following a suggestion from Stefan over in #2040375-28: Write tour integration for Appearance pages as it looks to me like the generic "test all the things" framework here belongs in TourTestBasic for the rest of us to inherit rather than copy&paste.

This one seems like a good thing to do, but postponed on #1921152-109: META: Start providing tour tips for other core modules. for now.

This doesn't need to be postponed per xjm in https://www.drupal.org/project/drupal/issues/1921152#comment-12348895

Attached is a patch that updates the tour from #27 with additional changes:

• Removes the UUID
• Adds status: true
• Updates order of attributes and formatting to replicate the views_ui tour
• Updates machine names to be consistent with file name/id (extend not modules)
• Removes deprecated attributes and location, replacing them with selector and position.
• Updated the order of tips in the yml to be the order of steps
• Added a tip for Updating modules (update tab)
• Text edits
• Selector edits
• Added the Tour into core/modules/system/config/optional

I've also attached a screen recording of the tour.

Will need a 10.1 patch

Also this will need tests.

This extension is being deprecated, see #3336033: [Meta] Tasks to deprecate Tour module. It will be removed from core and moved to a contrib project, #3376099: [11.x] [Meta] Tasks to remove Tour.

This is now Postponed. The status is set according to two policies. The Remove a core extension and move it to a contributed project and the Extensions approved for removal policies.

Will be added to new 2.0.x branch.

Removing the tests as for contrib not sure adding info warrants the tests. Just functionality.

Committed as part of new 2.0.x branch.