Adds a field for a simple way for content administrators to create accordions in nodes.

The author is presented a Title and a Hidden Text field in the edit screen. On the front-end of the site, the user see just the title. Upon clicking the title, the Hidden Text field content is slide toggled to reveal the hidden content.

Accordion Field does not provide any default styling, but does add classes where needed for styling.

https://drupal.org/sandbox/stolinski/2154827

git clone --branch 7.x-1.x http://git.drupal.org/sandbox/stolinski/2154827.git

Comments

pachabhaiya’s picture

pachabhaiya commented
Issue summary: View changes
pachabhaiya’s picture

pachabhaiya commented
Status: Needs review » Needs work

Hi Stolinski,
There is still a master branch, make sure to set the correct default branch: http://drupal.org/node/1659588. Then remove the master branch, see also step 6 and 7 in http://drupal.org/node/1127732.

Cheers!!!

Kirschbaum’s picture

Kirschbaum commented

Hi Stolinski,

I took some time to manually review the module. It works as advertised. I'm not seeing any issues. A couple comments:

  • Consider making jquery_update a dependency since this module is geared toward site-builders and requires JQuery 1.7
  • What distinguishes your module from the other accordion modules out there? It looks like this module https://drupal.org/project/accordions has field accordian functionality on the todo list: "Allow all sorts of types of content to be made into accordions, such as any entity, field or views row."

I really enjoyed reviewing this module. I learned a couple new things about fields. Thanks!

Stolinski’s picture

Stolinski commented
Status: Needs work » Needs review

Thanks!
The master branch has been removed.

Also added jQuery Update as a dependency.

As for what distinguishes this from accordions. It quickly and very easily adds a way for content administers to add one or many accordions to a node in a way that requires no configuration. I think there is merit to having the module that is just a field and doesn't need the ability to turn anything into an accordion.

Thanks!

** Also I set this to needs review, I wasn't sure the proper status for fixing needs work reviews.

PA robot’s picture

PA robot commented

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

th_tushar’s picture

th_tushar commented

Hi,
I have reviewed the code manually, and it looks fine. But when I installed the module, it didn't work as expected as per the issue description. Can you check it once at your end?
If possible, provide the proper demonstration of the module!!!

Thanks

vgalindus’s picture

vgalindus commented

Hi Stolinski,

I have reviewed the module and as th_tushar stated the name of the module can lead into error, IMO it should be named something like field toggle since it does not really allow you to show several "panels" in an accordion style.

A part from that I would suggest you adding documentation to your module page so people knows how it works and what to expect from it.

PS: Tag your issue with drupal version [D7] so people knows what version your module targets.

\BR

vgalindus’s picture

vgalindus commented
Status: Needs review » Needs work
PA robot’s picture

PA robot commented
Status: Needs work » Closed (won't fix)

Closing due to lack of activity. Feel free to reopen if you are still working on this application (see also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.

raulmuroc’s picture

raulmuroc commented
Status: Closed (won't fix) » Active

This is an interesting project because Views Accordion is for an entire Views while this project is for a specific EXISTING field: webform, login form, contact form...

Should be active to notice it stills need work.

gisle’s picture

gisle
he/him
Primary language Norwegian Bokmål
Location Norway
commented
Status: Active » Closed (won't fix)

It is up to the applicant (Stolinski) to reopen (and it if so noted problems should be fixed before reopening and status set to "Needs review").

There is no point in having it as an active item in the review queue if nobody is working on it.