This module is a duplicate of https://drupal.org/project/webreader

If it isn't, can you clarify the difference and why the community might choose yours over the other one?

Comments

killua99’s picture

killua99 commented

Let me explain this,

When I was search for some module that work with ReadSpeaker the only module I find was the official.

The official use the node system to print the "Listen" button.

Then yesterday or something I find the module you public here. The code from this module and the official one are almost 99% the same.

Using the "hook_node_view" to print the button. This means, if you're using a panels for a landing page, a home, or other entity you cannot use this module.

So I write this module using block system, this means you can control much better where put the button and play nice with the markup page because is a block and you can move more easily a block than a theme preprocess in the hook_node_view.

For extra I add a field to declare which ID I want to read. If I plan to read only a

in the block settings I can define that.

Extra I add the "Listen" with the function t, now I can translate to the language I want.

And last, the code of this module is more easy to read, more Drupal Standard code and best performance.

So this is an alternative, one use node view system, mine use block system.

Hope I answer your question and see the different.

pixelsweatshop’s picture

pixelsweatshop commented

These are nice enhancements and much needed IMHO. Is there a reason you chose to fork the module, rather than co-maintaining or providing a patch for the other one?

keopx’s picture

keopx
Primary language Basque
Location Basque Country
commented

nicoz, it is coincidence, because yesterday when I spoke with killua99 I saw we're working on same module, and I think the killua99 development is better than my code on webreader

Use this :D

pixelsweatshop’s picture

pixelsweatshop commented

Sounds good. Maybe we can put something on this project page (like the webreader module) that let's others know this as well.

keopx’s picture

keopx
Primary language Basque
Location Basque Country
commented
Status: Active » Closed (won't fix)

nicoz "redirect" webreader modulo to this, because this module development is better.

Thanks.

it-cru’s picture

it-cru
Primary language English
Location Munich
commented

Why not merge the D7 code of new created open_readspeaker module back to webReader module? So it would be also possible to re-factor the D6 code and have a longer existing module for the same function.

I can add killua99 as co-maintainer to webReader module.

it-cru’s picture

it-cru
Primary language English
Location Munich
commented
Status: Closed (won't fix) » Postponed
killua99’s picture

killua99 commented
Status: Postponed » Closed (fixed)

I'm not gonna merge. My reason in the comment above.

If some body need use the hook_node_view to print the button then can use the other module. I'll put that module as related.

When I have the enough time I write better the description.

Please keep this close.