Closed (fixed)
Project:
Webform
Version:
7.x-4.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
18 Oct 2013 at 09:55 UTC
Updated:
5 May 2014 at 02:00 UTC
Jump to comment: Most recent, Most recent file


Comments
Comment #1
spheresh commentedComment #2
spheresh commentedComment #2.0
spheresh commentedRelated issue
Comment #2.1
spheresh commentedaslo
Comment #3
spheresh commentedComment #4
quicksketchThanks, this seems like a reasonable improvement. The code needs to be improved slightly for translation purposes. We shouldn't be trying to reassemble the word day/month/year from a non-translatable source. Instead we should give each field an internal label, or pull it from existing properties (like maybe #attributes['title']).
Comment #5
spheresh commentedHi @quicksketch. Thank you for response. I think you are right. I will take a little bit of time for research the question and make some improve, although an internal label sounds good.
Comment #6
spheresh commentedComment #7
quicksketchThanks @spheresh! While testing your patch I found that it would skip the remainder of the validation (such as invalidating Feb 30) because a "return" was being called in all situations:
I made the "else" an "elseif (count($errors))" to make it so the return is only called if there's a missing value.
I've committed this patch to the project. Please let me know if you encounter any issues.
Comment #8
quicksketchSorry this version was actually committed. The previous version has an issue with not throwing an error on a completely empty required date.
Comment #10
fenstratNeeds porting to 8.x-4.x.
Comment #11
fenstratCommitted and pushed 2a37061 and 12cf059 to 8.x-4.x. Thanks!