[D7] Nodequeue References Dialog‎

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxspheresh2184425git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Hi @spheresh,

I reviewed your code, I found no blockers.
But some quotes seem to be inconsistent.
https://drupal.org/coding-standards#quotes

README file should contain a basic overview of what the module does and how someone may use it. See - https://drupal.org/node/161085.

- Add Description in README.txt file.
- Provide description for module file . (It says :- "@file * Main function." . Should be meaningful file description.)
- Please remove unused code.

/**
 * Implements hook_field_storage_create_field().
 */
function nodequeue_references_dialog_field_storage_create_field($field) {
  // @TODO@ May be a criation field will be there.
}

- Too many TODO things?

Git branch 7.x-1.x-dev is not needed.

Still several findings in PA automated review: http://pareview.sh/pareview/httpgitdrupalorgsandboxspheresh2184425git-7x-1x

README.txt

Please take a moment to make your README.txt follow the guidelines for in-project documentation.

Empty install file should be removed.

In nodequeue_references_dialog_node_type_form_validate, don't catch Exception, this is too broad. Catch the specific exceptions you wish to catch.

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.

@spheresh - any progress on your research? Do you still want to continue with this project application?

Ooops @spheresh was going to do some research - and hasn't reported back.

Perhaps you decided not to pursue this?

Postponing til we hear back.

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.