Closed (won't fix)
Project:
Drupal.org security advisory coverage applications
Component:
module
Priority:
Normal
Category:
Task
Assigned:
Reporter:
Created:
18 Feb 2014 at 08:01 UTC
Updated:
3 May 2014 at 16:27 UTC
Jump to comment: Most recent
Comments
Comment #1
PA robot commentedWe are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)
Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #2
draenen commentedI'm not sure this one feature deserves it's own module. You should consider submitting this as a feature request to the site_map module.
See http://pareview.sh/pareview/httpgitdrupalorgsandboxdrupaldelhi2199059git
sitemap_menu.info
Missing the dependency for site_map.
sitemap_menu.install
Lines 19, 25, 31, 37: The closing array parenthesis should be on a new line
Line 49: You do not need to call drupal_uninstall_schema() in the uninstall hook. This is done automatically by Drupal 7.
sitemap_menu.module
Line 5: First character should be capitalized.
Line 25, 57. 94: SELECT * queries should be avoided. Only the unset column is needed so sue fields('m', array('unset')).
Line 26, 59, 95: '=' is the default operation for SelectQuery::condition() and does not need to be explicitly passed.
Line 44: $form is passed by reference and should not be returned.
Line 50: Need a blank line before @see menu_edit_form()
Line 62: updation?
Line 65: Use db_update() for update queries.
Line 69: Use db_insert() for insert queries.
Comment #3
PA robot commentedClosing due to lack of activity. Feel free to reopen if you are still working on this application (see also the project application workflow).
I'm a robot and this is an automated message from Project Applications Scraper.