Only variables should be passed by reference in ctools_entity_from_field_context

I don't know much about patches. I've applied a couple over the last few years but I've never written one. When is it safe to say that a patch is good to go? Can I apply this now?

Hi Damien,

I actually have git. I've downloaded the patch. Would I simply want to place it in the ctools directory, navigate to that directory and issue the command: git apply -v [patch-name.patch]

Or does it not matter where the patch file is physically located when issuing this command?

Thanks!

CopperBot: I encountered this bug when I was doing a tutorial today and applied the patch in the video: http://www.youtube.com/watch?v=3stsc2BQj6s in 4:05. Hope that helps!

The patch works great and since it is pretty straightforward I mark this as RTBC.

See also these issues:
#2195211: Warning after update: Missing argument 4 for entity_metadata_taxonomy_access
#2195729: Warning: Missing argument 4 for entity_metadata_taxonomy_access() in entity_metadata_taxonomy_access()

The patch #1 here didn't solve the issue with commerce, however, as @maximpodorov pointed out, the issue #2195211: Warning after update has a patch that did solve this issue when coupled with the patch here.

The issue comes down to this line:
if (function_exists($to_entity_info['access callback']) && !call_user_func($to_entity_info['access callback'], 'view', $loaded_to_entity)) {
and is fixed in the other issue with:
if (function_exists($to_entity_info['access callback']) && !call_user_func($to_entity_info['access callback'], 'view', $loaded_to_entity, $account, $to_entity)) {

Since the original patch did not solve the problem, I am marking this back to "needs review".

First post on Drupal.org :-)
I needed to combine this patch with https://drupal.org/node/2195211, so I have complied both patches, and git diff'et to this file.

It is for 7.x.1-4

After addingthis patch, the strict warning goes, but I get this error:

Notice: Undefined index: access callback in ctools_entity_from_field_context() (line 181 of /home3/alphasa1/public_html/sites/all/modules/ctools/plugins/relationships/entity_from_field.inc).

Any ideas?

Many thanks, Joe

#14 is not combined completely, warning about 4 parameters still remains, so I`m making another one

Why do you combine patches for different issues?

Hiding combined patches to prevent confusion.

Patch from #1 made the strict warning disappear for me.

I've same issue using entity refernce as context in panels.
After pacth apply all warnings disappear.

This patch works for me, too

Works for me

#2195211: Warning after update: Missing argument 4 for entity_metadata_taxonomy_access went in, and the bonus coding standards fix in #1 conflicted with that fix, so I'm pretty sure this needs rerolling now.

1: ctools-n2195471-1.patch queued for re-testing.

Well, it still passes here because for some reason the d.o. bot is currently testing against the 7.x-1.4 release.

Output: [18319cd Require ctools 1.4].

If it keeps doing that then a re-rolled patch against a 7.x-1.x checkout would fail...

1: ctools-n2195471-1.patch queued for re-testing.

Ah, thanks!

Rerolled patch attached.

Green! @czigor, can you take a look and RTBC this once more?

Works and also looks good and trivial.

Patch in #34 passed because it's a renamed #29, not a renamed #1. :-)

And #1 does not apply anymore but it does apply against the current 7.x-1.x-dev build, which is 7.x-1.4+1-dev and needs rebuilding to 7.x-1.4+2-dev to sync with latest 7.x-1.x.

I did a simple reroll, commit credit goes to @DamienMcKenna!

#29 works for me too!

Thanks! Fixed.

http://drupalcode.org/project/ctools.git/commit/824c312

OK confused, using 7.x-1.4 and the patch fails.

I made the same mistake markbannister. This patch is not for 7.x-1.4. It is for 7.x-1.x dev (I believe)

When I downloaded the patch and looked at it the line numbers didn't match up with 7.x-1.4. I hope this is fixed with a new release (7.x-1.5) soon. I don't like having such an important module on my life site with a security vulnerability but I can't exactly go with 7.x-1.4 (due to this error message) and I'm not about to put a dev copy on my live site either.

That being said thank you to all the parties involved in working on this module.

It's a strict warning, not a security error or such. And it's also generally advised to not display warnings on a live/production site.

If the patch won't apply (usually line numbers don't have to be exact), just edit the file yourself if you really can't stand the warning.

Attaching a patch that cleanly applies to 7.x-1.4 – and of course it solves the problem: there's no warning any more.

Update to my comment #14

Issue n2195211 address some issues with Entity entity_metadata_user_access and this issue addresses ctools_entity_from_field_context - both patches are for the same file in ctools/plugins/ and when trying to apply both it fails - thats the reason for this patch - overlapping linenumbers.

And third update (this IS my first patch on Drupal) - now with a file actually working, combining the overlapping issues from n2195471 and n2195211

@mudderklirren, you made exact patch that i did in #16, but with one syntactis mistake, no space after last "if"

It was my understanding it is never recommended to use dev copies of a module on a production site DamienMcKenna.

Hey @DamienMcKenna, just curious to know a potential timeline for a stable release that will include this fix?
Thank you for all your hard work here!
-Miro

For the record: #47 worked for me as applied to ctools 7.x-1.4.

Thanks everyone.

I fixed changing this line (ctools 7.x-1.4)

$loaded_to_entity = array_shift(entity_load($to_entity, array($to_entity_id)));

for this ones

$loaded_to_entity = entity_load($to_entity, array($to_entity_id));
$loaded_to_entity = array_shift($loaded_to_entity);

Only variables should be passed by reference

http://php.net/manual/es/function.array-shift.php

@juanramonperez, just use the 1.5 version of Ctools, it has this fix in it.

@MrHaroldA sure I will. thanks.