[D7] Commerce Interkassa-new Payment

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxmerdekiti2192803git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Hello merdekiti,
Just a reminder: you should add "PAReview: review bonus" in the issue tag to get the attention of the reviewers.

All the best,
Feyisayo

Good to see another Ukrainian developer around!

What about the module:

1) Following the unofficial commerce payment method naming "convention", you should rename it to "Commerce Interkassa".

2) The package name should be changed to Commerce (contrib) not Commerce.

3) commerce_payment_interkassa.module line 278 - Making a copy of the global user object is safer so you don't accedentily modify the global. Consider $user = $GLOBALS['user']; instead of global $user;

Removing review bonus tag, you have not done all manual reviews, you just posted the output of an automated review tool. Make sure to read through the source code of the other projects, as requested on the review bonus page.

I think you should join forces with commerce_interkassa module (version 2.x).
Creating another module for the same gateway makes confusion.

Agreed, a 2.x branch in the existing module sounds like a good idea. Module duplication and fragmentation is a huge problem on drupal.org and we prefer collaboration over competition. Please open an issue in the commerce_interkassa issue queue to discuss what you need. You should also get in contact with the maintainer(s) to offer your help to move the project forward. If you cannot reach the maintainer(s) please follow the abandoned project process.

If that fails for whatever reason please get back to us and set this back to "needs review".

Closing due to lack of activity. Feel free to reopen if you are still working on this application (see also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.