Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
translation.module
Priority:
Minor
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
3 Sep 2013 at 14:24 UTC
Updated:
29 Jul 2014 at 22:52 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
mrsinguyen commentedComment #2
parthipanramesh commentedpatch failed to apply..
Comment #3
xjmLet's also check for other unused local variables in the translation module.
Comment #4
xjmComment #5
Rajesh Ashok commentedComment #6
Rajesh Ashok commentedRemoved unused local variables in the content_translation module.
Comment #7
Rajesh Ashok commentedComment #8
izus commentedthere are some unused
usestatements.will upload a patch within minutes
Comment #9
izus commenteddeleted some use statements that seems to be unused.
hopefully this goes green !
Comment #10
izus commentedThis one wasn't realy meant, i'll fix it back
Comment #11
izus commentedComment #12
izus commentedhere it is again
Comment #13
id.medionThe patch cannot be applied.
Comment #14
internetdevels commentedReroll attached.
Comment #15
internetdevels commentedRemoved tag "Needs Reroll"
Comment #16
eugenesia commented14: drupal-core-remove-unused-local-variables-from-translation-module-2080559-14.patch queued for re-testing.
Comment #18
eugenesia commentedPatch in #14 couldn't be applied as content_translation_menu() was removed in the latest dev version of the module.
Comment #19
eugenesia commentedRerolled patch #14. Also verified with PhpStorm that the content_translation module doesn't have any unused variables or imported namespaces.
Comment #20
connorwk commentedHere at the Austin sprint.
Going to re-roll and review this.
Comment #21
connorwk commentedOk so I made a new patch because I realized in the current patch that I was working on re-rolling there are a lot of
usestatements removed that are not used. This is good work but is out of the scope of this issue and should have a new issue made for it or be put in one already existing for it.There was only one unused local variable in the content_translation module reported by phpStorm so I made a patch for that.
Should just need review and this issue should hopefully be RTBC.
Comment #22
sunAgreed that the use statements are out of scope.
Comment #24
alexpottCommitted aedaf11 and pushed to 8.x. Thanks!