[D7]custom token features

• You are using few hooks from features module, however you did not declare any dependency for feature module.
• Implements document style is not followed
• PAReview : There are standard related issues reported. These are not application blockers but its nice to clean them up, if you have time.
• Your module is name as custom_token_features, however the files are named fe_custom_token. This might confuse few, i believe we can change this to a standard & use any one name.
• README.txt Template : there is an standard Readme template, if you can follow that standard which would be good.

Please manually review 3-4 Projects & have a review bonus tag added to your application. Project applications with review bonus always get priority

Besides what was said above it works fine.

It doesn't look like any of the issues identified in comment #1 have been addressed.

Please take a look at the Status settings for an issue page for some guidelines on when an item can move from "Needs work" to "Needs review" states. As gobinatham identified in comment #1 there are changes that need to take place before this project can be properly reviewed and approved.

Needs Work ["CNW"]
There is a patch attached to the issue, but the patch needs additional work before it should be reviewed. The author of the patch may indicate that it is incomplete, or the patch has gone through the reviewing process and has received feedback about areas where it needs improvement.

Hi Harshil,

I install all the required modules in my local environment.
create an default custom token as site information and current user.
when I try to create new feature it shows my two custom tokens in the features create page.
I generate one feature using my custom token, and enable this generate feature in another drupal installation.
But it will not give me result as expected. It need to create users data under new drupal installation.

Please suggest if I am doing wrong, also one more thing every time while before creating new feature I need to clear website cache.
otherwise I am not able to my custom tokens in create new feature screen.

@harshil.maradiya, 2 things here -

1) You have not mentioned your sandbox project page link.

2) Fix all the errors & warnings pointed out by PAReview (see attached). Other reviewers have already pointed out this in #1, #6 and (again in #9).

Being not application release blocker(s), leaving you at "Needs review" with the hope that these are fixed!

No real issues application blocker issues identified as of last commit. Hence changing status to RTBC

Hi Harshil, your module folder name is custom_token_features and module name is fe_custom_token, I'ts not strictly required to have same name, but for naming consistency it should have.

Component name should not start with same name as module, I believe that's the reason for issue reported on #12 (no tokens being exported).

fe_custom_token_config

So:

  return array(
    'fe_custom_token_config' => array(
      'name' => 'Custom token features ',
      'file' => 'fe_custom_token.features.inc',
      'default_hook' => 'fe_custom_token_config_features_default_settings',
      'feature_source' => TRUE,
    ),
  );

should be something like:

  return array(
    'custom_token_cfg' => array(
      'name' => 'Custom token features ',
      'file' => 'fe_custom_token.features.inc',
      'default_hook' => 'custom_token_cfg_features_default_settings',
      'feature_source' => TRUE,
    ),

And all corresponding features api hooks should be renamed according.

Looks like your functions are still not named correctly? See http://pareview.sh/pareview/httpgitdrupalorgsandboxharshilmaradiya220962...

Project page is not clear: what request from 2011? Please provide a link. Does this depend on https://www.drupal.org/project/token_custom ? Please fill out your project page according to https://www.drupal.org/node/997024 .

Maybe you mean that there has not been any development on token_custom since 2011? Why can't this module live as a submodule in token_custom then?

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.