[D7] Gumby for Drupal

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxtravisc2093067git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

@travisc , I have a few suggestions to make concerning your theme:

1) One file in particular - gumby.min.js can be seen at 2 places - gumby/js/libs/gumby.min.js & gumby/gumby.min.js respectively. Please remove the duplicate file (Besides, all js files can go to the /js directory).

2) Please remove files such as demo.html, index.html, ui.html etc. that are strictly not required to be part of the theme.

3) Consider removing the extra space(s) at the end of L9, L31, L45 in the html.tpl.php. As per https://drupal.org/coding-standards "Lines should have no trailing whitespace at the end." Please make sure that all your files follow this standard.

4) html.tpl.php is not ending in newline (\n). As per https://drupal.org/coding-standards "All text files should end in a SINGLE newline (\n). Please make sure that all your files follow this standard.

Closing due to lack of activity. Feel free to reopen if you are still working on this application (see also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.

When reopening, the status should be the status it was in when closed (i.e. "Needs work").

To get a review, you need to: 1) fix the problems; and 2) Set status to "Needs review".

Note that it will be automatically closed again if you haven't changed status to "Needs review" 70 days after reopening.

Category was wrong as well.

3rd party code/content

No:

The theme re-packages a lot of 3rd party assets from the Gumby Framework. It also includes a 3rd party font and pictograms from Entypo. Third party assets are not allowed on Drupal.org and should be deleted.
The Gumby assets are made available under the MIT license. This is considered a GPL-compatible license, which is usually allowed, but explicit permission to use from Drupal.org webmasters is still required.
The Entypo materials is under CC BY-SA 3.0 and the SIL Open Font License. This violates policy, since all assets hosted on Drupal.org must be licensed under the GPL V2+ license.
This policy is described in the 3rd party libraries and content on Drupal.org. It also appears in the Drupal Git Repository Usage policy you agreed to when you signed up for Git access, which you may want to re-read, to be sure you're not violating other terms.
The Libraries API module is a recommended method for adding 3rd party dependencies without directly including the code on Drupal.org.

Hi travisc,

As gisle mentioned, you need to use the Libraires API module to load third party code at installation time. So with proper code in your module, all third-party required code will be downloaded to the libraries folder at install time.

You can consult the developer documentation here:
https://www.drupal.org/node/1342238

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.