[D7] Askom

Do you have a link the sandbox project and have the code in a git repo?

You should remove the generated fields from your info file:

; Information added by drupal.org packaging script on 2011-01-08
version = "7.x-1.1"
core = "7.x"
project = "askom"
datestamp = "1294500066"

; Information added by drupal.org packaging script on January 1, 1970 - 00:00
version = "7.x-1.2"
core = "7.x"
project = "askom"
datestamp = "1295326592"

You need a function comment block for:

• hook_help()
• askom_admin_settings_form()

You need a file comment block for:

• askom.module
• askom.admin.inc

Git clone command for the sandbox is missing in the issue summary, please add it.

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

I'm almost certain that you'll need to have your code in your sandbox's git repo in order to be granted full project status.

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxdialogfeed2195517git

I'm a robot and this is an automated message from Project Applications Scraper.

Hello Askom,
Thanks for the work.

The Git repository link you have in the comments is not correct. I had to infer what your Git link was from the PA Robot's comment.

Please add the correct link to your description ie

git clone --branch 7.x-1.x http://git.drupal.org/sandbox/dialogfeed/2195517.git

In addition, there are numerous formatting issues with your code. Please see http://pareview.sh/pareview/httpgitdrupalorgsandboxdialogfeed2195517git for the current report.

Best wishes,
Feyisayo

Dear askom,
thanks for your work so far on the module.

Firstly, you should be working in a version-specific branch, not master.
View https://drupal.org/empty-git-master and perform that change.

Secondly, you have to fix all errors presented by pareview.sh:
http://pareview.sh/pareview/httpgitdrupalorgsandboxaskom2190447git
These will probably seem tedious and many will not make sense at first,
but they are important in keeping up the "standard practices" of the
Drupal community.

Good luck,

imgio

@askom, while waiting for others to review your project, the very first thing you can do yourself is to fix all warnings and errors in - http://pareview.sh/pareview/httpgitdrupalorgsandboxdialogfeed2195517git

You can fix these as mentioned below:

README.txt
=========

All 5 warnings relate to: "Line exceeds 80 characters"

Solution: You can shorten it by just hitting Enter key (just before the 80th character) and start on new line. That's it. For more details please check: https://drupal.org/coding-standards#linelength

askom.admin.inc
============

The 2 warnings relate to: 'Format should be "* Implements hook_foo()" '

Solution: Replace function doc comment on line 9 with:

/**
* Implements askom_admin_settings_form()
* @return array
*/

and

Replace function doc comment on line 42 with:

/**
* Implements askom_admin_settings_form_validate()
* @param $form
* @param $form_state
*/

askom.install
=============
Likewise, on line 9 and 27 respectively add these function doc comments:

/**
* Implements hook_install().
*/

and

/**
* Implements hook_uninstall().
*/

askom.module
=============
Similarly, please fix other warnings here in this file.
The lone ERROR is self explanatory: "askom_requirements() is an installation hook and must be declared in an install file"

Let me guide you to this link: http://webwash.net/articles/how-notify-site-builders-if-something-requir...

Hope it helps!!

@askom, in your .install file, as you have declared $t = get_t();

Line 18 should follow the below syntax:

'title' => $t('askom module'),

rather than

'title' => $t = 'askom module',

Similarly, fix the lines 19 & 21 as well. More info here - https://drupal.org/node/322731

Leaving you on "Needs review", with the hope that you fix these. Also, that should take care of the lone warning that is left :-).

Hi!
Way to speed up approving is to do PAReview bonus https://drupal.org/node/1975228
Having a review bonus will put your module application on the high priority list, see https://groups.drupal.org/node/142454

That is not an application blocker, please do a real review of the source code.

Generally I found this to look good. I only found a couple of things that I think need to be cleaned up before this is ready to be released:

• The ASKOM ID is not validated
  • The askom_admin_settings_form_validate function validates that the ID is not blank, but it needs a more thorough check. It may be possible to inject code into the page if this value is maliciously constructed.
• The path returned by askom_requirements is incorrect
  • The link to the settings form returned when the module is not configured is incorrect. It currently returns admin/settings/askom, when I believe it should be admin/config/system/askom
  • You should wrap that in the url() function.

There are still things missing, like the help text, and the ability to administer other settings, but I assume that those are coming.

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.