This module allows developers and themers to make use of the Freewall jQuery plugin. It includes a developer API that other modules can use, as well as Views integration in the 3.0 version so that you can turn any list of content or images into a responsive grid layouts. This project is similar to projects Isotope Views, Masonery API and Views Fluid Grid.

- Sandbox: https://drupal.org/sandbox/arnion/2203119
- Freewall proyect: http://vnjs.net/www/project/freewall/
- git clone --branch 7.x-1.x http://git.drupal.org/sandbox/Arnion/2203119.git freewall
- Isotope Views: https://drupal.org/project/views_isotope
- Masonry: https://drupal.org/project/masonry
- Views Fluid Grid: https://drupal.org/project/views_fluidgrid

CommentFileSizeAuthor
Freewall.png200 KBArnion
Pinterest layout.png415.08 KBArnion
Grid layout.png340.21 KBArnion

Comments

PA robot’s picture

Status: Needs review » Needs work

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxArnion2203119git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

phaer’s picture

  • The git uri which does not need authentication is http://git.drupal.org/sandbox/Arnion/2203119.git . You might want to change that to make copy & paste easier for reviewers.
  • Please stick to the Coding standard, as the bot told you :)
  • I guess the directory "contib" should be named "contrib".
  • Line 44ff of fireewall.module looks like you should use a loop and....
  • I am not sure what Drupals policy is on loading external content for demos, but i'd recommend "//" as url scheme instead of "http://" because it works with https:// too without browser warning that unsafe content is getting loaded.
  • .brick as class name seems a bit too generic to me, what's about ".freewall-brick" to avoid collisions?
  • as far as I know, hook_init() is called only once per request, so in my understanding
     static $css_added = FALSE;
      if($css_added === FALSE) {
      [...]
        $css_added = TRUE;
      }
    

    in freewall_example_views.module does not make any difference?

Arnion’s picture

Issue summary: View changes
PA robot’s picture

Status: Needs work » Closed (won't fix)

Closing due to lack of activity. Feel free to reopen if you are still working on this application (see also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.

w van casteren’s picture

Hey Arnion,

I am trying to make Freewall available for drupal 8
I have gotten it configured more or less like your version in drupal 7.
But i can't get it to work the way it does in drupal 7.

The result is on:
http://bart.vanherreweghe.biz/pad
the libraries get loaded, I enter freewall.js with drupalsettings. But somehow the classes data-... are not changed, added.

Can you help me I would be willing to add this module somewhere on drupal.org. If only i would get it to work.

Regards
Wilfred