Remove all calls to drupal_json_decode(), use \Drupal\Component\Utility\Json::decode()

Deprecated drupal_json_decode() by Json::decode().

Looks like this needs a reroll, plus there are no use statements anywhere for Drupal\Component\Utility\Json.

Rerolled and added use statements. It looks like a bunch of calls to json_decode were switched over as well, including in vendor files, so I switched those back.

Its my fault :( Thanks rbayliss. I have test the patch its working fine for me.

Is there a reason why we still have drupal_json_decode() in the following places left?

views_ui/lib/Drupal/views_ui/Tests/TagTest.php
53:    $matches = (array) json_decode($result->getContent());
59:    $matches = (array) json_decode($result->getContent());
68:    $matches = (array) json_decode($result->getContent());

block/tests/Drupal/block/Tests/CategoryAutocompleteTest.php
68:    $this->assertSame(MapArray::copyValuesToKeys($suggestions), json_decode($result->getContent(), TRUE));

system/lib/Drupal/system/Tests/Form/FormTest.php
437:    $values = json_decode($this->drupalPostForm('form-test/range', array(), 'Submit'));
467:      $result = json_decode($this->drupalPostForm('form-test/color', $edit, 'Submit'));

system/lib/Drupal/system/Tests/Form/CheckboxTest.php
68:    $results = json_decode($this->drupalPostForm('form-test/checkboxes-zero', array(), 'Save'));
73:    $results = json_decode($this->drupalPostForm('form-test/checkboxes-zero', $edit, 'Save'));

system/lib/Drupal/system/Tests/Database/SelectTableSortDefaultTest.php
41:      $data = json_decode($this->drupalGetContent());
69:      $data = json_decode($this->drupalGetContent());

system/lib/Drupal/system/Tests/Database/TemporaryQueryTest.php
42:    $data = json_decode($this->drupalGetContent());

system/lib/Drupal/system/Tests/Database/SelectPagerDefaultTest.php
48:      $data = json_decode($this->drupalGetContent());
82:      $data = json_decode($this->drupalGetContent());

ckeditor/lib/Drupal/ckeditor/Plugin/Editor/CKEditor.php
212:    $toolbar_settings['buttons'] = json_decode($toolbar_settings['buttons'], FALSE);

edit/lib/Drupal/edit/Tests/EditLoadingTest.php
256:      $ajax_commands = drupal_json_decode($response);
275:      $ajax_commands = drupal_json_decode($response);

That looks like a definitive list to me.

Are we going to replace json_decode() with Json::decode() as well?

Alright. I attached the patch with the missing replacements.

Uploading an interdiff between #9 and #17 used for the review.

I agree that replacing json_decode itself would be out of scope.

Patch no longer applies.

Rerolled the patch.

#20: 2093173-remove_calls_drupal_json_decode-20.patch queued for re-testing.

Tags

The patch doesn't apply anymore and needs to be re-rolled again.

Re-rolling patch from comment 20.

My apologies, I think some typos are behind this. I'm submitting a new one shortly..

Trying this again.

Grr..sorry I'll take another stab at this tonight or tomorrow :(

The re-roll failed when I tried to apply it and it's getting late. I'll get back to this soon.

Sorry, @forbesgraham, It's been a while :)

We need to keep the scope of this patch intact, so the changes to the expected values in the tests that were changes (like views-uiedit > views-ui-edit) break the tests. Even though they are indeed wrong, this is not the place the fix them.

Also, some missing conversions in tests.

Just a tiny bit.

+++ b/core/modules/rest/lib/Drupal/rest/Tests/CreateTest.php
@@ -7,6 +7,9 @@
+use Drupal\rest\Tests\RESTTestBase;

+++ b/core/modules/menu/lib/Drupal/menu/Tests/MenuTest.php
--- a/core/modules/rest/lib/Drupal/rest/Tests/CreateTest.php
+++ b/core/modules/rest/lib/Drupal/rest/Tests/CreateTest.php

+++ b/core/modules/rest/lib/Drupal/rest/Tests/CreateTest.php
@@ -7,6 +7,9 @@
 namespace Drupal\rest\Tests;

This base class exists in the same namespace, so we don't have to add it.

34: 2093173-34.patch queued for re-testing.

Do not created interdiff, because can`t apply old patch.

I rerolled patch. Now it should apply cleanly.

Patch after reroll applies cleanly for me. I verified codebase by using cscope, and it haven't detected call to drupal_json_decode().
It seems that it works OK now.

At implementation level, it's only simple substitutions, nothing fancy here.

I'll work on this.

Tests pass locally, run test again.

42: replace-drupal-json-decode-2093173-41.patch queued for re-testing.

fixing tag. sorry for noise.

Rerolled, removed a new reference in EditorSecurityTest, and a documentation reference in the JSON utility class itself.

Thanks!

Previous patch only applied with fuzz, rerolled, still should be RTBC.

55: 2093173-remove-drupal_json_decode-55.patch queued for re-testing.

Rerolled, again

Looks like we're missing a change notice about this: https://drupal.org/list-changes/published?keywords_description=drupal_js...

This should be done as part of #2208607: Write script to automate replacement of deprecated functions where possible, so writing a patch should be postponed on that.

I've posted a draft change record at https://drupal.org/node/2219113 which needs review.

Using Function Replacer Part of Write script to automate replacement of deprecated functions where possible.

$ function_replace.php drupal_json_decode 'Drupal\Component\Utility\Json' UtilityJson decode

Patch is a good reroll of the earlier (manual) patch. Most of the changes are either merge conflicts or the use statements being in a different order.

The one real change is that the scripted patch doesn't remove the @see drupal_json_decode() from the new function's docblock, but that's probably better removed with the function itself anyway.

Strictly speaking I don't think this requires a change record as we're not actually removing the old functions, but there is a draft at https://drupal.org/node/2219113 anyway.

Yeah, prob doesn't need a CR? As we are just converting the core usages of the function?

Committed 880f697 and pushed to 8.x. Thanks!

The change record just needed to be published.

Removed 'Needs change record' tag.