Closed (fixed)
Project:
Manual Crop
Version:
7.x-1.x-dev
Component:
Code
Priority:
Critical
Category:
Bug report
Assigned:
Reporter:
Created:
10 Mar 2014 at 12:53 UTC
Updated:
8 May 2014 at 21:00 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
merlinofchaos commentedThis patch fixes the fatal, though I don't know if it fixes it correctly -- it keeps working and seems to do what I would like it to do.
Comment #2
magicmyth commentedThanks for the patch merlinofchaos. Its working just fine for me.
Comment #3
matthijsPatch committed, thanks!
Comment #4
morenstratI still get this error with the latest Manualcrop dev and Media 2.0-alpha3 on node/add/* fot content types that have field using the media widget:
Comment #5
bkildow commentedI'm getting the same issue.
Attaching the manualcrop_media_element_process on #after_build at the root of $element, instead of looping over the element_children and attaching it there seems to have fixed it for me ($element var in manualcrop_media_element_process() will then contain $entity_type, $bundle, etc.).
This looks like it was the approach before the patch in #1, so I'm not sure what changed...
Comment #6
matthijsThis is probably because you're using alpha 3 instead of the latest dev version?
Comment #7
morenstratI can confirm that the patch from #1 fixes the problem only with the latest dev version of the media module, not the alpha3.
It would be nice to have a manualcrop release that goes along with the alpha3 version of the media module. Manualcrop 7.x-1.4 is not an option because it depends on an older Drupal core version.
Comment #8
antonyanimator commentedThis is fixed when using the latest media dev version.
Unfortunately, there are some bugs in the latest media dev which won't allow me to use it.
Therefore I have to use https://drupal.org/comment/8608583#comment-8608583 version of the media module.
Comment #9
matthijsI've added a check to determine if a newer version than alpha 3 is being used, if not the previous code will be used.