[D7] Commerce Fidelity Paygate

Hello,

Thank you for contributing.

1/ Your .info and .api.php files are empty.
2/ Delete your master branch.
3/ It should say: git clone --branch 7.x-1.x http://git.drupal.org/sandbox/togbonna/2192407.git commerce_fidelity_paygate

NerOcrO

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Hi togbonna,

Great to see that your module passed everything in http://pareview.sh/ :)

After a manual review, my major concern is that in commerce_fidelity_paygate_get_response(), the $response variable is set by directly calling both $_GET and $_POST, which exposes a potential security issue. The $response value should really be set based on the user's chosen method in the settings form with something like an if/else statement pulling in values from $form_state.

Also, it looks like in the module's settings, users will ultimately choose whether to use the web service or $_GET to make the request. I would further suggest that this module stick with just one implementation, preferably the web service, assuming there aren't any major functional differences.

Closing due to lack of activity. Feel free to reopen if you are still working on this application (see also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.

Multiple Applications

It appears that there have been multiple project applications opened under your username:

Project 1: https://www.drupal.org/node/2209133

Project 2: https://www.drupal.org/node/2064317

Project 3: https://www.drupal.org/node/1606388

Project 4: https://www.drupal.org/node/1102706

As successful completion of the project application process results in the applicant being granted the 'Create Full Projects' permission, there is no need to take multiple applications through the process. Once the first application has been successfully approved, then the applicant can promote other projects without review. Because of this, posting multiple applications is not necessary, and results in additional workload for reviewers ... which in turn results in longer wait times for everyone in the queue. With this in mind, your secondary applications have been marked as 'closed(duplicate)', with only one application left open (chosen at random).

If you prefer that we proceed through this review process with a different application than the one which was left open, then feel free to close the 'open' application as a duplicate, and re-open one of the project applications which had been closed.

I'm a robot and this is an automated message from Project Applications Scraper.

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxtogbonna2192407git

I'm a robot and this is an automated message from Project Applications Scraper.

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.