[D7] mailredirect7

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxjopmesman2113033git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

I did a review of your project and found the following things to consider

Your Git URL is incorrect, it should be "git clone http://git.drupal.org/sandbox/jopmesman/2113033.git mailredirect7"

You should also edit your first post and include a link to your project page: https://drupal.org/sandbox/jopmesman/2113033

There are a few missing t() functions. In includes/mailredirect7_admin.inc, line 51 and 64 (the #title elements), but I don't think those should hold up the application process.

Aside from the missing t functions, the code looks really good. I can see how this module would be helpful and does not appear to be in competition with any other modules. Thanks for taking the time to submit it.

Changes the branche in clone command.

Possible Duplication

It seems that these modules provide similar functionality. Could you describe how your module differs?

• Mail Redirect - https://drupal.org/project/mail_redirect
• Reroute Email - https://drupal.org/project/reroute_email
• Advanced Mail Reroute - https://drupal.org/project/advanced_mail_reroute
• Maillog / Mail developer - https://drupal.org/project/maillog

We prefer collaboration over competition, therefore we want to prevent having duplicating modules on drupal.org. If the differences between these modules are not too fundamental for patching the existing one, we would love to see you joining forces and concentrate all power on enhancing one module. (If the existing module is abandoned, please think about taking it over).

If that fails for whatever reason please get back to us and set this back to "needs review".

I did not do a full review.

----
Top Shelf Modules - Crafted, Curated, Contributed.

I reviewed your project.
http://pareview.sh/pareview/httpgitdrupalorgsandboxjopmesman2113033git-7...

I found a few problems that you should solve.

• You have still a few warnings in automatic review. It would be fine if you solve them.
• In hook_menu() you are using a path like "admin/settings/mailredirect7"
  These kind of paths are for Drupal 6. In Drupal 7 you should use something like
  "admin/config/system/mailredirect7"
  Please change this address in all places. (e.g. in mailredirect7_test.inc and README.txt)
• change "Implemens hook_perm()." to "Implemens hook_permission()."
• In hook_permission, you should not break description in two lines. If you need to break the line, you should use the string join operator (.)
• You have multiple strings not wrapped by t().
• You are using variables in your module (you've called system_settings_form()). So you should implement the hook_uninstall() and delete all your variables there.
• Email address should not be written as "emailaddress" !

Closing due to lack of activity. Feel free to reopen if you are still working on this application (see also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.