Closed (won't fix)
Project:
Drupal.org security advisory coverage applications
Component:
module
Priority:
Minor
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
9 Apr 2014 at 20:06 UTC
Updated:
14 Aug 2014 at 10:26 UTC
Jump to comment: Most recent
Comments
Comment #1
prabeen.giri commentedUsing master branch is not recommended. Delete master branch and work with version specific branch like 7.x-1.x, 7.x-1.x-dev .
Also I can see errors on pareview.sh
http://pareview.sh/pareview/httpgitdrupalorgsandboxheymp2237031git
Comment #2
PA robot commentedWe are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)
Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #3
GoRoost commentedAgree with prabeen.giri in comment #1.
- Here is a link related to changing your branch and removing master: https://drupal.org/empty-git-master
- The errors in the PAReview are very easy to fix, and should be addressed.
- Does not appear to be a duplicate. There are other modules that allow the include of Enquire.js, but none that seem exclusive to this library.
Comment #4
kevla commentedHad a look at the code for this now.
One thing that's puzzling me is that you've defined a global variable at the top, I can't see where its used. Is it really required?
Also, how come you've added the library with drupal_add_js instead of libraries_load()?
In summary though I'd suggest:
1. Remove the master branch
2. Fix http://pareview.sh/pareview/httpgitdrupalorgsandboxheymp2237031git (Mostly not putting capital letters at the beginning of comments and an empty line at the bottom of the module file)
Comment #5
kevla commentedComment #6
scotthooker commentedHad a look at the code. All appears fine however several issues with your submission
1. As other people have mentioned remove the master branch
2. heyMP@git.drupal.org:sandbox/heyMP/2237031.git is the wrong address for git you need to supply the link for normal users. This is YOUR link.
Comment #7
heyMP commentedThanks for the feedback, I'll make those changes!
Comment #8
heyMP commentedI've corrected the formatting issues, the errant global variable and replaced the master branch with a dev branch.
kcmanc87, I've seen drupal_add_js in various modules that utilize the Libraries API. Is libraries_load() better for than drupal_add_js in this instance?
Comment #9
kevla commentedlibraries_load() will include all the dependencies too I believe.
Comment #10
saurabh-chugh commentedHi,
1) I don't know but why have you made README.md file instead of README.txt
2) "heyMP@git.drupal.org:sandbox/heyMP/2237031.git" is the wrong address for git you need to add like "git clone http://git.drupal.org/sandbox/heyMP/2237031.git enquirejs".
3) It seems to be OK module to me, however I suspect it for going it as separate project/module.
Thanks
Comment #11
heyMP commentedComment #12
PA robot commentedClosing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).
I'm a robot and this is an automated message from Project Applications Scraper.