This is my first contrib module, and my first project application as well, so please forgive me if I miss something. Nearest I can tell in my searching, there is no module which addresses this use-case.

Project description:
Demote Filter is an input filter which will "demote" heading tags by one level. <h1> tags become <h2>, <h2> become <h3> etc.

This can be useful when using a WYSIWYG editor in order to bump down generated heading tags for the purposes of SEO.

Project URL:
https://drupal.org/sandbox/reubidium/2230123

Repo path:
git.drupal.org:sandbox/reubidium/2230123.git

Thank you for consideration,
Reuben

Comments

PA robot’s picture

PA robot commented
Status: Needs review » Needs work

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxreubidium2230123git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

david_garcia’s picture

david_garcia commented

Great job, this module looks interesting!

Overall code looks OK and I could find no coding standard issues. (I dont' know why the automated tool says it does...).

What I found:

[1] Some more inline comments as to what the code is doing.
[2] Readme.md should be Readme.txt, and also revise the content take a look at template (https://drupal.org/node/2181737) or other modules.

[3] You are using form's validation to perform processing:

function _demote_filter_headings_settings_validate($form, &$form_state) {
$form_state['values']['add_class'] = trim($form_state['values']['add_class']);
}

Validation is validation, and is intended only for checks.

You can use the submit handler for that. If you want your submit handler to be the first in the submit validation chain, use array_unshift() on the form's validation array.

Something like:

array_unshift($form['#submit'], '_demote_filter_headings_settings_validate');

or depending on how the form is built:

array_unshift($form['actions']['submit']['#submit'], '_demote_filter_headings_settings_validate');

PA robot’s picture

PA robot commented
Status: Needs work » Closed (won't fix)

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.