Closed (won't fix)
Project:
Drupal.org security advisory coverage applications
Component:
module
Priority:
Major
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
5 Mar 2014 at 06:05 UTC
Updated:
7 Jul 2014 at 16:26 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
drupalbabaji commentedComment #2
drupalbabaji commentedComment #3
PA robot commentedThere are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxashishdrupal2166215git
We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)
Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #4
drupalbabaji commentedComment #5
drupalbabaji commentedComment #6
prabeen.giri commentedHi,
On your install file , I did not understand why are you using hook_disable instead of hook_uninsatll. In most of the cases, hook_uninstall should be used to delete the variables that are created.
Comment #7
drupalbabaji commentedComment #8
drupalbabaji commentedComment #9
drupalbabaji commentedHi prabeen
Deleting variables in hook_disable is my requirement, i want that as user disable module all variables should delete. I am using these variables to check checkboxes by default and i do not want if user re enable module will find checkboxes checked by previous configuration.
Comment #10
stred commentedHi drupalbabaji,
Here is my review
the title of this issue should be [D7]allowed-value-list ...
the Wish List Features is clear... but from my point of view greatly limit the use of the module...
typo in .admin.inc 155 Permssion edited
+ a lot of others, in comments as well
you should manage to get a fully featured module because to be able to only add new values is not very useful. your module should manage edit and delete items as well, it's a pity.
Comment #11
drupalbabaji commentedComment #12
PA robot commentedClosing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).
I'm a robot and this is an automated message from Project Applications Scraper.