The redundancy 'revert back' will be removed from core so we will need to update the tests so that they pass.

CommentFileSizeAuthor
#7 diff-revert_back-2450949-6.patch1.5 KBlhangea
#1 2450949-1.patch658 byteslhangea
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

lhangea’s picture

lhangea CreditAttribution: lhangea commented
FileSize
2450949-1.patch658 bytes
miro_dietiker’s picture

miro_dietiker
Location Switzerland
CreditAttribution: miro_dietiker at MD Systems GmbH commented

"will be removed" or is already?
Any link to the original issue?

Straight forward HEAD fixes due to core changes don't need extensive RTBC review if things are covered by tests and they were broken and pass again.

lhangea’s picture

lhangea CreditAttribution: lhangea commented

Once it will be removed. The link is in the related issues.

miro_dietiker’s picture

miro_dietiker
Location Switzerland
CreditAttribution: miro_dietiker at MD Systems GmbH commented

Updated the core task to RTBC. Let's see how long it takes. :-)

lhangea’s picture

lhangea CreditAttribution: lhangea commented
Status: Postponed » Needs work
miro_dietiker’s picture

miro_dietiker
Location Switzerland
CreditAttribution: miro_dietiker at MD Systems GmbH commented

Yeah, the core issue is committed. This needs a reroll.

lhangea’s picture

lhangea CreditAttribution: lhangea commented
Status: Needs work » Needs review
FileSize
diff-revert_back-2450949-6.patch1.5 KB

Updated test assertions so that the tests pass.

lhangea’s picture

lhangea CreditAttribution: lhangea commented
Status: Needs review » Reviewed & tested by the community

  • lhangea committed 492d4a7 on 8.x-1.x 
    Issue #2450949 by lhangea: assertText fails after 2383015 is commited to...
lhangea’s picture

lhangea CreditAttribution: lhangea commented
Status: Reviewed & tested by the community » Fixed
lhangea’s picture

lhangea CreditAttribution: lhangea commented
Assigned: lhangea » Unassigned

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.