Signature of user_pass_rehash() function has changed since Drupal 7.35 as a part of the security fix, we have to pass user ID to it from now on. Patch follows.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Dmitriy.trt’s picture

klausi’s picture

Status: Active » Reviewed & tested by the community

I was just working on the exact same patch :-)

Works for me, thanks!

  • Dmitriy.trt authored a2af0e7 on 2455393-fix-core-7-35-compat
    Issue #2455393 by Dmitriy.trt - Compatibility with Drupal 7.35.
    

  • Dmitriy.trt authored a2af0e7 on
    Issue #2455393 by Dmitriy.trt - Compatibility with Drupal 7.35.
    

  • Rob C committed 6963288 on 2455393-fix-core-7-35-compat authored by Dmitriy.trt
    Issue #2455393 by Dmitriy.trt - Compatibility with Drupal 7.35.
    

  • Rob C committed 6963288 on 7.x-1.x authored by Dmitriy.trt
    Issue #2455393 by Dmitriy.trt - Compatibility with Drupal 7.35.
    
Rob C’s picture

Status: Reviewed & tested by the community » Fixed

Tested, committed, merged.

Thanks for the patch + for also updating tests!

Will roll a new RC later today.

Apologies for the spam, got wrong active git credentials.

klausi’s picture

vladan.me’s picture

This really needs to be asap 7.x.-1.4 since a lot of people will update Drupal without knowing that this module will break and when it does, it breaks bad ;)

Rob C’s picture

Everybody is able to download the 1.4-rc2, see https://www.drupal.org/node/1050930/release

For some reason it's not added as the latest version anymore on the project page and i'm unable to select 1.4-rc2 as the current adviced version, but i won't be releasing 1.4 this month, we need a bit more time to test things.

vladan.me’s picture

Yes, it's more about advised version, less about naming. I have no idea either why it's not updated...

klausi’s picture

1.4-rc2 is not the latest stable version, since a rc release can never be a stable version. The project page shows the latest stable version which is 1.3.

Rob C’s picture

I've seen it work for release candidates before, no idea when this changed. 7.x-1.3-rc1 was also a release candidate and was listed on the project page for some time. I'll create the 1.4 soon enough anyway, give it a couple weeks +/-.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

rudiedirkx’s picture

Releasing beta's and rc's during stable is useless, because Drupal won't show them on the project page and Drush won't download them.

There is of course an issue for that: #647428: Show latest prerelease (if different from recommended release) with dev releases

Still, this module should work around it and release 1.4 IMO.

Rob C’s picture

Voila: https://www.drupal.org/node/2485845 (might take a couple hours for it to generate the archive)

sh radhoush’s picture

it is incompatible with drupal 7.34. how can I fix it with a patch?

Rob C’s picture

All versions before 1.4-RC2 are compatible with everything below core 7.35. But won't guarantee anything (like security).

You could try to revert this patch, but the idea is to only update the module when you update drupal core to 7.35. (that's what this issue is about).

rudiedirkx’s picture

And you should update Drupal core to 7.35, because it's a security update.