Updates are run in definition order, not numeric order. [#246143]

Create a module and enable it. Create two update functions, _1 and _2, and declare them in most-recent first order:

function mymod_update_2() {
  drupal_set_message('update 2');
}

function mymod_update_1() {
  drupal_set_message('update 1');
}

Run update.php and see the output. Notice that only update_2() runs.

Initial patch against 5.x attached but it applies to HEAD. This patch needs tests and, IMHO, should then be back-ported to 6.x and 5.x.

Comment	File	Size	Author
#5	install-update-order-246143-3.patch	783 bytes	Damien Tournoud
#3	install-update-order-246143-3.patch	858 bytes	floretan
	install-update-order.patch	512 bytes	bjaspan

Comments

Comment #1

Damien Tournoud CreditAttribution: Damien Tournoud commented 13 April 2008 at 16:54

Priority:	Critical	» Normal
Status:	Active	» Needs work

I'm not sure there are any real-world consequences for that bug, so that's not critical. Any way, I can confirm that bugs. All updates functions in install.php and update.php expects the result of drupal_get_schema_versions() to be sorted, while nothing in the drupal_get_schema_versions() contract guarantees that.

I have not tested the patch. On review, it looks good, but the change in the behavior of the function (ie. the results will always be ordered) should be documented in its doxygen comment.

Comment #2

bjaspan CreditAttribution: bjaspan commented 14 April 2008 at 01:13

Priority:

Normal

» Critical

The real-world consequence is that foo_update_1() will never be run and foo_update_2() will be. That's bad and complete violates the specification for update functions.