Follow up issue to add tests.

Issue fork entity_visibility_preview-3135436

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Grimreaper created an issue. See original summary.

bakop’s picture

bakop
Primary language French
CreditAttribution: bakop at Smile commented
Assigned: Unassigned » bakop

bastienkopka opened merge request !5

bakop’s picture

bakop
Primary language French
CreditAttribution: bakop at Smile commented
Assigned: bakop » Unassigned
Status: Active » Needs review

Hi, i created the test that allow to see if fields are used in the entity.

Please review the MR.

Thanks.

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
CreditAttribution: grimreaper at Smile commented
Status: Needs review » Needs work

Hello,

Thanks for your work, review done with points.

bakop’s picture

bakop
Primary language French
CreditAttribution: bakop at Smile commented
Assigned: Unassigned » bakop
bakop’s picture

bakop
Primary language French
CreditAttribution: bakop at Smile commented
Assigned: bakop » Unassigned
Status: Needs work » Needs review

Hello, it should be good now !

Can you review it please ?

Thanks.

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
CreditAttribution: grimreaper at Smile commented
Status: Needs review » Needs work

Hello,

Thanks for the work done. Almost there, the general idea of the test is here.

We can see the remaining points if you want.

bakop’s picture

bakop
Primary language French
CreditAttribution: bakop at Smile commented
Status: Needs work » Needs review
grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
CreditAttribution: grimreaper at Smile commented
Assigned: Unassigned » grimreaper
Status: Needs review » Needs work
grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
CreditAttribution: grimreaper at Smile commented
Status: Needs work » Needs review

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
CreditAttribution: grimreaper at Smile commented
Assigned: grimreaper » Unassigned
Status: Needs review » Fixed
grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
CreditAttribution: grimreaper at Smile commented

I didn't mean to squash the commits...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.