Errors on search-only for deep-nested paragraphs

I applied your patch @mariacha1, but I'm still seeing the same error as you when searching (haven't tried replacing yet)

Error: Call to undefined method Drupal\paragraphs\Entity\Paragraph::getTitle()

I definitely need something that goes more than 2 levels deep. Did you make any more progress with this?

Generating a patch for both mariacha1 fixes with some minor tweaks.. Also added a method_exists() check on getTitle()

Fixing additional getTitle()

I think this does not take into account the fact that paragraphs could be attached to other types of entities, though. For example, we have a block type that we use with layout builder, that has a paragraph on it, that then nests another paragraph in that (Accordion Items, Accordion Item, ex.g.).

I think perhaps we need to traverse getParentEntity() until the parent entity type !== 'paragraph'?

We get 'call to undefined function BlockContent::getParentEntity()' even with this patch applied.

@cwells, that is a good recommendation.. I do not have time to look into that currently. Is that something you could test??

Yes, that seems to work much better. I have a test site where I have a paragraph with paragraphs in it. I have applied that pattern to a custom block type and a node. No more breaking with block_content. I think it requires a re-think of iterating on paragraphs until you get to a non-paragraph. Updated patch.

Thanks!

Thank you for working on this, it's appreciated.

The patch needs a reroll. And I think some test coverage would be best to ensure it works as expected and doesn't break in the future.

Core Drupal 8.9.16. I have a relationship of "node -> paragraph ->nested paragraph" entity reference. I have tried applying the patch https://git.drupalcode.org/project/scanner/-/merge_requests/1.diff

Error: Drupal\Core\Entity\Query\QueryException: 'wp_page_header_v1' not found in Drupal\Core\Entity\Query\Sql\Tables->ensureEntityTable() (line 368 of /Users/projects/web/core/lib/Drupal/Core/Entity/Query/Sql/Tables.php).

Patch for nested paragraphs issue, tested on rc-4

Rerolling patch #15 for rc6

I have applied the patch in #20. It applies cleanly to rc6 and works as expected. Thanks!

This still errors for me with a nested paragraph:
ResponseText: Error: Call to undefined method Drupal\block_content\Entity\BlockContent::getParentEntity() in Drupal\scanner\Plugin\Scanner\Paragraph->search() (line 73 of /app/docroot/modules/contrib/scanner/src/Plugin/Scanner/Paragraph.php).

That error indicates there's a block being loaded, not a paragraph; we probably need to update the logic to protect against that.

It's a paragraph inside a block that's loading.

I needed to reroll the patch in #20 for 1.0-rc7. I made a couple of code formatting tweaks but left the logic alone - there are some things in there that are a little unusual, goto and while(1==1) , that make it a little hard to follow. It probably needs a little more work.

Thanks for rerolling it, glad to see the tests pass now.

The patch needs work:

1. This line:

+          checkPE:

+            if (is_null($parentEntity)) goto checkPE;

That gives off some bad code smell.

2. This part needs cleaning up:

+                // Two or more levels of nesting.
+                else {
+                  if (!is_null($parentEntity->getEntityTypeId())) {
+                    while (1 == 1) {
+                      if (is_null($parentEntity)) break;
+                      $tempA = $parentEntity->getEntityTypeId();
+                      if (is_null($tempA)) break;
+                      if ($tempA == 'node') break;
+                      $parentEntity = $parentEntity->getParentEntity();
+                    }
+                  }
+                }

Last patch gives me:

An AJAX HTTP error occurred.
HTTP Result Code: 200
Debugging information follows.
Path: /batch?id=410&op=do_nojs&op=do
StatusText: parsererror
ResponseText: Error: Call to undefined method Drupal\paragraphs\Entity\Paragraph::getTitle() in Drupal\scanner\Plugin\Scanner\Paragraph->search() (line 115 of /app/web/modules/contrib/scanner/src/Plugin/Scanner/Paragraph.php).

Edit - Accidentally posted twice

Modified patch from #25 to address issues from #28

I tried the patch from #30 on D10.2 site, but I still get the error reported in #28.

If a parent entity doesn't have getParentEntity() method, it returns the error below:

Error: Call to undefined method Drupal\block_content\Entity\BlockContent::getParentEntity() in Drupal\scanner\Plugin\Scanner\Paragraph->search() (line 70 of /var/www/html/web/docroot/modules/contrib/scanner/src/Plugin/Scanner/Paragraph.php)

I can confirm the issue from #33 regarding incompatibility with block_content (which is quite widely used). I created a separate issue for that now: #3485911: Incompatibility with block_content module

MR!1 looks very promising and the logic is much better than the existing. I think we should stop posting patches and instead finish the MR!1. Could someone please check, which changes the MR is missing from the comments and update it accordingly?

I also left some comments. I think we're quite close to fixing this!

Closed #3485911: Incompatibility with block_content module as duplicate.

Can we update for 2.0.x please

Just wanted to add some notes from https://www.drupal.org/project/scanner/issues/3448005 which I think can be closed as a duplicate, because this approach should (at least from my local testing) resolve the issue over there. Does need a reroll, which I can try and take a look at.

Setup
1. Drupal 10.3
2. Scanner 1.0/2.0 beta
3. ERR 1.12
4. Paragraphs 1.18
5. Setup as above
6. Add a new paragraph with a string field
7. Add a paragraphs field to the basic page content type, allow references to the new paragraph
8. Add a new basic page
9. Use 'old paragraph value' as the string
10. Save
11. Edit this node
12. Remove the old paragraph, add a new one, use 'new paragraph value' as the field value
13. Save
14. In scanner, search for 'old paragraph value'
15. Expected: 0 results
16. Actual: 0 results
17. Search for 'new paragraph value'
18. Expected: 1 result
19. Actual: 1 result

I've created a patch based on the current merge request, but it can be applied to version 2.0.0-beta1.

Let's try to fix this for v2.0.0.

The getTitle() change was moved into #3200455: Call to a member function getEntityTypeId().

Some changes have gone into Scanner that affect the Paragraphs integration, could someone please reroll this? Thank you.

This needs refactoring after #3584678: Refactor search logic to use a method in Entity class was committed.

I added test coverage in MR!69 that shows pretty deeply nested paragraphs does seem to work now, possibly through some of the refactoring done elsewhere. Can someone please test the current dev version and let me know if the problem still exists for searching only, if so please help expand the test to show the problem and we can look into it further.

BTW I've refactored the Paragraphs search logic in #3586025: Refactor Paragraphs search using improved Entity::search() method, so I'd really like to hear if you can confirm problems.

Going to assume this is working correctly now, please open a new issue if you spot any problems. Thank you everyone!