Problem/Motivation

In layout builder the default details.html.twig file appears to not work well within layout builder.

Proposed resolution

Maybe have a generic template for layout builder that doesn't include the usa-accordion stuff.

CommentFileSizeAuthor
#3 Screen Shot 2021-07-09 at 1.53.17 PM.png60.96 KBsmustgrave
Screen Shot 2021-07-08 at 3.30.34 PM.png60.54 KBsmustgrave

Issue fork uswds_base-3222882

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

smustgrave created an issue. See original summary.

smustgrave opened merge request !14

smustgrave’s picture

smustgrave CreditAttribution: smustgrave at Mobomo commented
Status: Active » Needs review
StatusFileSize
new Screen Shot 2021-07-09 at 1.53.17 PM.png60.96 KB

Tried to keep it simple. Doing a check for layout builder if it's there suggest a new template. And that template I copied from seven (removing seven classes). Now it looks much better.

smustgrave’s picture

smustgrave CreditAttribution: smustgrave at Mobomo commented

This is best used with this patch also https://www.drupal.org/project/drupal/issues/3223048#comment-14159865. Currently the filtering hides the link but the li tag has padding styling that doesn't get hidden.

mferanda’s picture

mferanda CreditAttribution: mferanda as a volunteer commented

The change seems perfect to resolve the issue. However, I'm having trouble seeing this issue myself to test.

Fully admit that I do not use layout builder.

Please provide some steps including if I need some sort of specific content to duplicate the issue.

Thank you

smustgrave’s picture

smustgrave CreditAttribution: smustgrave at Mobomo commented

Sure.

If you're on a layout builder display and click to "Add a block" the off canvas menu will appear on the right. Currently the sections look a little off and it's not clear they collapse. This change just cleans that up.

Separate issue is when you try and do a search it does filter but the css on the li causes spacing issue. This appears on all themes it appears and that's what this patch does https://www.drupal.org/project/drupal/issues/3223048#comment-14159865

smustgrave’s picture

smustgrave CreditAttribution: smustgrave at Mobomo commented

Just following up on this ticket

mferanda’s picture

mferanda CreditAttribution: mferanda as a volunteer commented

Reviewing. Thank you for contributing

mferanda’s picture

mferanda CreditAttribution: mferanda as a volunteer commented

Okay, I see it and it looks good. Simple change for increased core functionality / compatibility. Will get this merged in for the next version push (probably the last to get the next version out)

mferanda’s picture

mferanda CreditAttribution: mferanda as a volunteer commented
Status: Needs review » Patch (to be ported)

  • mferanda committed a0fd3ee on 8.x-2.x authored by smustgrave 
    Issue #3222882 by smustgrave: Details template seems broken in layout...
mferanda’s picture

mferanda CreditAttribution: mferanda as a volunteer commented

I just pushed out 2.11-rc1. Will be testing on my end soon to push out 2.11 stable ASAP. Multiple changes but are all pretty simple.

mferanda’s picture

mferanda CreditAttribution: mferanda as a volunteer commented
Status: Patch (to be ported) » Fixed
mferanda’s picture

mferanda CreditAttribution: mferanda as a volunteer commented
Status: Fixed » Closed (fixed)