In #3083615: Check if scheduled transitions are valid for editing user, a feature was introduced which denies users access to editing nodes that are scheduled to a transition they don't have access to.
While this is the right way to do in most cases, there might be situations where this behavior is not desired.
In our case, we have a Person node type, which represents employees of a company. Some of them might have fixed-term contracts, so we use the Scheduler module to make sure they get unpublished automatically when the contract ends. We're also using Content Moderation with a pretty much default setup with an Editor role that is not allowed to publish or archive.
In this scenario, it feels wrong to deny access to editors. They should be able to create new drafts, which may be published by users with the appropriate permission, until finally the node gets unpublished automatically when the 2-year period is over.
Allow admins to opt in or out to this behavior through a configuration setting. Perhaps it's even necessary to do this on a per-bundle basis.
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | scheduler_content_moderation_integration-remove_transition_check-3274274-2.patch | 2.28 KB | mrshowerman |
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #2
mrshowermanHere's a patch that simply removes the access check. This is of course not the solution, but it might be handy for others who have the same scenario.
Comment #3
jonathan1055 commentedHi @mrshowerman,
Yes I think you have a valid use case for wanting to allow the Editor to make changes, in preparation for an authorised user (let's call them the Manager) to make it current. As an alternative to making the access check a configurable option, maybe there is a way to let the Editor update the content but not have access to alter the scheduling date or scheduled state. They would make a new draft of the content, and the Manager could then edit, make it 'published' manually (to replace the existing published content) and set the unpublish date and state. There might even be a way to automatically extract the existing unpublish date and state, so that the Manager does not have to re-do it.
Some ideas to think on ...
Comment #4
mrshowermanStrangely enough, this seems already be the case in our setup with above patch: Person entities get created by a Manager, including a scheduled unpublish date. Editors can create new drafts, which can be published by the Manager. But all these changes don't affect the scheduled unpublish date; it keeps the value that was set initially.
I understand that the motivation for introducing the access check in #3083615: Check if scheduled transitions are valid for editing user was to avoid unwanted changes to the scheduled states when a node is updated by someone with just Editor permissions, but so far I failed to reproduce such a behaviour, even after having removed the access check.
Comment #5
smustgrave commentedI like the idea of a simple setting. Or maybe a permission to "bypass SCMI access" to be applied to roles. Thoughts?
Comment #6
jonathan1055 commentedNew features will first be done in the 3.x branch.
Comment #8
mrshowermanCreated an MR which adds a permission to bypass the access check.
Comment #9
smustgrave commentedCan we get a test for this new feature.
Comment #10
bkosborneMarked #3336702: If user doesn't have access to scheduled state, they are unable to edit the scheduled content as a duplicate of this.