Problem/Motivation

In an exposed form that is set to "Input required", filters that are rendered as a non-multiple select box retrieve an "All" entry as first option.
This feels wrong from a user perspective, since the "All" option should have no effect and never show results.

Steps to reproduce

Add an exposed filter to a view, uncheck "multiple" and choose the "Input required" exposed form style.

Proposed resolution

Replace the "All" option with "Please select".

CommentFileSizeAuthor
#7 input_required_replace_all-3300709-7.patch1.96 KBmrshowerman
#4 interdiff_2-4.txt1.17 KBmrshowerman
#4 input_required_replace_all-3300709-4.patch1.96 KBmrshowerman
#2 input_required_replace_all-3300709-2.patch2.27 KBmrshowerman

Comments

mrshowerman created an issue. See original summary.

mrshowerman’s picture

mrshowerman
Location Munich
commented
Title: Views select filters shouldn't contain an "All" option when "Input required" setting is active » [PP-1] Views select filters shouldn't contain an "All" option when "Input required" setting is active
Assigned: mrshowerman » Unassigned
Status: Active » Needs review
Parent issue: » #3300701: Expose "input required" setting
StatusFileSize
new input_required_replace_all-3300709-2.patch2.27 KB

Attached patch is making use of the inputRequired() method proposed in #3300701: Expose "input required" setting, thus adding a dependency.

smustgrave’s picture

smustgrave commented
Status: Needs review » Needs work
Issue tags: +Needs tests

Don't see any test coverage for this so moving back to NW

mrshowerman’s picture

mrshowerman
Location Munich
commented
Status: Needs work » Postponed
StatusFileSize
new input_required_replace_all-3300709-4.patch1.96 KB
new interdiff_2-4.txt1.17 KB

Renamed inputRequired() to isInputRequired().
Changing status to Postponed since we depend on #3300701: Expose "input required" setting.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.9 was released on December 7, 2022 and is the final full bugfix release for the Drupal 9.4.x series. Drupal 9.4.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.5.x-dev branch from now on, and new development or disruptive changes should be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

mrshowerman’s picture

mrshowerman
Location Munich
commented
StatusFileSize
new input_required_replace_all-3300709-7.patch1.96 KB

Re-roll.

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.