Problem/Motivation

In #3347343: Add Views EntityReference filter to support better UX for exposed filters, a new EntityReference views filter type will be added, while #3300709: [PP-1] Views select filters shouldn't contain an "All" option when "Input required" setting is active is about replacing the "All" option with "Please select" for filters rendered as a select box when the "Input required" setting is active.

This issue aims to bring the two together.

CommentFileSizeAuthor
#14 entity_reference_respect_input_required-3300714-14.patch1.08 KBmrshowerman
#11 entity_reference_respect_input_required-3300714-11.patch1.08 KBmrshowerman
#8 entity_reference_respect_input_required-3300714-8.patch1.08 KBmrshowerman
#6 entity_reference_respect_input_required-3300714-6.patch895 bytesmrshowerman
#4 entity_reference_respect_input_required-3300714-4.patch69.9 KBmrshowerman
#2 expose_input_required-3300701-3.patch1.08 KBmrshowerman

Issue fork drupal-3300714

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

mrshowerman created an issue. See original summary.

mrshowerman’s picture

mrshowerman
Location Munich
commented
Assigned: mrshowerman » Unassigned
Status: Active » Needs review
StatusFileSize
new expose_input_required-3300701-3.patch1.08 KB

Attached patch will work only after applying #2429699-491: Add Views EntityReference filter to be available for all entity reference fields and #3300709-2: [PP-1] Views select filters shouldn't contain an "All" option when "Input required" setting is active.

mrshowerman’s picture

mrshowerman
Location Munich
commented
Title: Respect the "Input required" setting in Views EntityReference filter » [PP-2] Respect the "Input required" setting in Views EntityReference filter
mrshowerman’s picture

mrshowerman
Location Munich
commented
Status: Needs review » Postponed
StatusFileSize
new entity_reference_respect_input_required-3300714-4.patch69.9 KB

Renamed inputRequired() to isInputRequired().
Changing status to Postponed since we depend on two other issues.

mrshowerman’s picture

mrshowerman
Location Munich
commented
mrshowerman’s picture

mrshowerman
Location Munich
commented
StatusFileSize
new entity_reference_respect_input_required-3300714-6.patch895 bytes

#4 by mistake contained all changes from the upstream issue; this one contains only the relevant change.

mrshowerman’s picture

mrshowerman
Location Munich
commented
mrshowerman’s picture

mrshowerman
Location Munich
commented
StatusFileSize
new entity_reference_respect_input_required-3300714-8.patch1.08 KB

This one should do it.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.9 was released on December 7, 2022 and is the final full bugfix release for the Drupal 9.4.x series. Drupal 9.4.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.5.x-dev branch from now on, and new development or disruptive changes should be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

mrshowerman’s picture

mrshowerman
Location Munich
commented
Issue summary: View changes
Parent issue: #2429699: Add Views EntityReference filter to be available for all entity reference fields » #3347343: Add Views EntityReference filter to support better UX for exposed filters
StatusFileSize
new entity_reference_respect_input_required-3300714-11.patch1.08 KB

Update to latest state in MR of #3347343: Add Views EntityReference filter to support better UX for exposed filters

mrshowerman’s picture

mrshowerman
Location Munich
commented
Title: [PP-2] Respect the "Input required" setting in Views EntityReference filter » [PP-1] Respect the "Input required" setting in Views EntityReference filter
Assigned: Unassigned » mrshowerman
Status: Postponed » Active
mrshowerman’s picture

mrshowerman
Location Munich
commented
Title: [PP-1] Respect the "Input required" setting in Views EntityReference filter » [PP-2] Respect the "Input required" setting in Views EntityReference filter
mrshowerman’s picture

mrshowerman
Location Munich
commented
StatusFileSize
new entity_reference_respect_input_required-3300714-14.patch1.08 KB

Re-roll.

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.