Blocked on #3293469: Automated A11y tests in Nightwatch, which performs the checks that surfaced this

Problem/Motivation

The tests added in #3293469: Automated A11y tests in Nightwatch identified the following when visiting the homepage, /user/login, and presumably any page with primary tabs:

NightwatchAssertError
08:56:57    aXe rule: region - All page content should be contained by landmarks
08:56:57 	In element: #primary-tabs-title

If this a11y error is considered acceptable (either false positive or there's a tradeoff that provides greater benefit), it's possible to leave something unfixed, but the rationale should be documented within the code.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Comments

bnjmnm created an issue. See original summary.

steinmb’s picture

steinmb commented
Status: Postponed » Active

#3293469: Automated A11y tests in Nightwatch is now in, unblocking

bnjmnm’s picture

bnjmnm
he/him
Primary language English
Location Ann Arbor, MI
commented
Title: [PP-1] Address Primary tabs "missing region" A11y test failure » Address Primary tabs "missing region" A11y test failure
mgifford’s picture

mgifford
he/him
Primary language English
commented

Just noting that this is a Deque best practice, rather than a WCAG SC. Still important.

https://dequeuniversity.com/rules/axe/4.7/region

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.

quietone’s picture

quietone commented
Status: Active » Postponed

The Olivero theme was approved for removal in #3590816: [policy, no patch] Deprecate Olivero and move to contrib.

This is Postponed. The status is set according to two policies. The Remove a core extension and move it to a contributed project and the Extensions approved for removal policies.

The deprecation work is in #3595082: [meta] Tasks to deprecate the Olivero theme and the removal work in #3595085: [meta] Tasks to remove the Olivero theme.

kentr’s picture

kentr commented
Component: Olivero theme » Admin theme
Status: Postponed » Postponed (maintainer needs more info)
Parent issue: » #3585823: [Meta] Improve the accessibility of the Default Admin theme
Related issues: +#3583486: Adjust default_admin's top bar to the landmark used with the navigation module

I'm seeing this in Default Admin when running tests for #3338664: Migrate Nightwatch Axe tests to PHPUnit.

The element in the error is #primary-tabs-title, which is different than what I saw for #3583486: Adjust default_admin's top bar to the landmark used with the navigation module. So, I think it's occurring separately under different conditions.

Needs STR, though. I only see it in the automated tests, not in the browser using the same installation profile.