Problem/Motivation

Despite release claiming compatibility with Drupal ^9.0 || ^10, at least one setting does not work with Drupal <9.3.

When matomo.js caching is turned on, website crashes with error in PHP log.
Uncaught PHP Exception Symfony\Component\DependencyInjection\Exception\ServiceNotFoundException: "You have requested a non-existent service "file_url_generator".

Service in question was implemented in Drupal 9.3.

Steps to reproduce

Install Matomo, configure it and turn on matomo.js caching in settings. Clear caches and visit website.

Proposed resolution

Bump version compatibility to ^9.3 || ^10.

Issue fork matomo-3374118

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

t_d_d created an issue. See original summary.

vinodhini.e’s picture

vinodhini.e commented
Assigned: Unassigned » vinodhini.e
vinodhini.e’s picture

vinodhini.e commented
Assigned: vinodhini.e » Unassigned

jeeva r made their first commit to this issue’s fork.

jeeva r opened merge request !76

jeeva r’s picture

jeeva r commented
Assigned: Unassigned » jeeva r
Status: Active » Needs review
vinodhini.e’s picture

vinodhini.e commented

Hi,
I have merged the code changes that provide compatibility with both Drupal 10 and 11. Thanks.

jeeva r’s picture

jeeva r commented
Assigned: jeeva r » Unassigned
j-lee’s picture

j-lee
he/him
Primary language German
Location 🇩🇪🇪🇺
commented

I think, the Drupal 11 fixes should go to the 2.0 branch?

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Version: 8.x-1.21 » 8.x-1.x-dev
Assigned: Unassigned » grimreaper
grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented

Deprecations for 8.x-1.x branch had been fixed in #3546318: Manual Drupal 11 compatibility fixes for matomo 8.x-1.x.

But 8.x-1.x remains marked as compatible with D9 which is not supported.

I will create a new MR because the https://git.drupalcode.org/project/matomo/-/merge_requests/76/ is doing what had been done in the other issue but less efficiently.

I will also increase minimum requirements so no more need of the deprecations helper if possible.

grimreaper closed merge request !76

grimreaper opened merge request !86

grimreaper opened merge request !87

  • grimreaper committed d3db174f on 2.0.x 
    feat: #3374118 increase Core minimum requirement.

By: t_d_d
By:...

  • grimreaper committed 9d5b8f5c on 8.x-1.x 
    refactor: #3374118 Update from changes from 2.0.x

By: grimreaper

  • grimreaper committed 0f67a563 on 8.x-1.x 
    feat: #3374118 increase Core minimum requirement, remove deprecation...
grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Assigned: grimreaper » Unassigned
Status: Needs review » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.