Describe your bug or feature request.

I initially started converting all plugin types to attributes from within a single issue (#3463795: Convert CheckoutFlow, CheckoutPane, NumberPattern, PaymentGateway, PaymentMethodType, PaymentType, TaxType, TaxNumberType to attributes.), but I think it is better if we split the conversion into several issues.

Let's focus on Commerce conditions here.

Issue fork commerce-3463959

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

jsacksick created an issue. See original summary.

jsacksick’s picture

jsacksick commented

Haven't converted OrderBillingAddress and OrderShippingAddress yet due to the arbitrary key that is used there ("profile_scope").
It doesn't feel right for the attribute constructor to define it, but I wonder what alternative we have here...

jsacksick opened merge request !283

  • jsacksick committed e44453f7 on 3.0.x 
    Issue #3463959 by jsacksick: Convert Commerce condition plugins to...
jsacksick’s picture

jsacksick commented
Status: Active » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.