Describe your bug or feature request.

The constructor of SebastianBergmann\Comparator\ComparisonFailure changed in the version that is pulled with D11. I'm just not sure how to address this?
Should we introduce a ComparisonFailureBridge class that instantiates the SebastianBergmann\Comparator\ComparisonFailure differently based on the Drupal core version?

 ------ ------------------------------------------------------------------ 
  Line   modules/order/src/Comparator/AdjustmentComparator.php             
 ------ ------------------------------------------------------------------ 
  31     Class SebastianBergmann\Comparator\ComparisonFailure constructor  
         invoked with 6 parameters, 4-5 required.                          
 ------ ------------------------------------------------------------------ 
 ------ ------------------------------------------------------------------ 
  Line   modules/price/src/Comparator/NumberComparator.php                 
 ------ ------------------------------------------------------------------ 
  30     Class SebastianBergmann\Comparator\ComparisonFailure constructor  
         invoked with 6 parameters, 4-5 required.                          
 ------ ------------------------------------------------------------------ 
 ------ ------------------------------------------------------------------ 
  Line   modules/price/src/Comparator/PriceComparator.php                  
 ------ ------------------------------------------------------------------ 
  28     Class SebastianBergmann\Comparator\ComparisonFailure constructor  
         invoked with 6 parameters, 4-5 required.    

Issue fork commerce-3465986

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

jsacksick created an issue. See original summary.

  • jsacksick committed 3802b671 on 3.0.x
    Issue #3465986 by jsacksick: Create a bridge ComparisonFailure class to...
jsacksick’s picture

Status: Active » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.