Hey there,
In https://git.drupalcode.org/project/views_bulk_operations/-/commit/01cee7... you refactored a bunch of classes and changed the notation of parameters in the __construct methods. But in the same process, you marked them as readonly which provides some BC issues.
We noticed ConfigureAction to be problematic in cases in which the action plugin config form uses a more complex, ajax based logic which serializes and unserializes the form. And when this happens, it errors out with:
Error: Cannot initialize readonly property Drupal\views_bulk_operations\Form\ConfigureAction::$tempStoreFactory from scope Drupal\Core\Form\FormBase in Drupal\Core\Form\FormBase->__wakeup() (line 81 of /var/www/html/build/core/lib/Drupal/Core/DependencyInjection/DependencySerializationTrait.php).
...namely, it cannot reinstantiate the form because the parameter is now readonly and cannot be set from the parent class which uses the dependency serialization trait. So we need to add it also to this class or remove the readonly support.
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | 3482226-4.patch | 837 bytes | upchuk |
| #2 | 3482226-2.patch | 658 bytes | upchuk |
Issue fork views_bulk_operations-3482226
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
upchuk commentedComment #3
graber commentedCool but let's also add a comment why it's needed so someone will not remove it in the future by mistake.
Comment #4
upchuk commentedHere you go. Are there no tests running?
Comment #5
graber commentedI think there's no testing of patches now, only for old branches that had it set previously, and it's impossible to set it on new branches anymore, you'd have to set up a MR. I don't think this needs a test though.
Comment #6
graber commentedI'll reword it a bit tomorrow so it's clear this ahppens during AJAX requests on config forms and commit.
Comment #7
onfire84 commentedThx, run today in the same issue. Patch #4 works for me.
Comment #9
graber commentedAnd of course I forgot. Thanks for commenting and triggering a notification.
Comment #10
graber commentedComment #11
harlor commentedGreat! - @graber are you planning to release a 4.3.2 for this?
Comment #12
harlor commentedSorry accidentally changed status...
Comment #13
graber commentedYes, let's just wait a couple of days, maybe there'll be more findings.